WIP: (Predrag) Update go from 1.24.0 to 1.24.2 #20770

minikube-bot · 2025-05-15T20:26:33Z

This PR is meant for debugging for @prezha

Kubernetes Project just updated the golang version, updating minikube golang to match Kubernetes.

This PR was auto-generated by make update-golang-version using update-golang-version.yml CI Workflow.

closes #20785

minikube-bot · 2025-05-15T20:26:34Z

ok-to-build-image

k8s-ci-robot · 2025-05-15T20:26:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-05-15T20:26:42Z

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

medyagh · 2025-05-15T21:08:44Z

ok-to-build-iso

minikube-bot · 2025-05-15T21:21:59Z

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

nirs · 2025-05-16T00:21:44Z

go.mod

@@ -1,7 +1,6 @@
 module k8s.io/minikube

-go 1.23.4
-toolchain go1.24.1
+go 1.24.2


Do we really want to make this the minimal required version? This may break people using packages from minikube.

that is a good feedback, I would accept a PR that updated the Automation to not bump the minor version in go mod.
I think it would probably best to Match what kubernetes does.
which they dont bump the patch version for go mod
https://github.com/kubernetes/kubernetes/blob/master/go.mod

good point, i pulled in go version from the current go.mod (v1.24.0) and resolved the conflicts

minikube-bot · 2025-05-16T03:03:21Z

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

medyagh · 2025-05-16T18:31:07Z

/ok-to-test

medyagh · 2025-05-16T18:38:02Z

/ok-to-test

medyagh · 2025-05-16T19:53:01Z

ok-to-build-iso

minikube-bot · 2025-05-16T23:03:46Z

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

This PR addresses issue kubernetes#20770, where the minikube automation (triggered by make `update-golang-version`) unnecessarily bumped minor or patch versions in `go.mod` when updating the Go version. Following Kubernetes' practice, which avoids such bumps in `go.mod`, this change ensures only the go directive is updated to the stable Go version. **Changes:** - Added `go.mod` to the schema map in `hack/update/golang_version/update_golang_version.go` with a regex (go 1\.\d+\.\d+) to update the go directive to {{.StableVersion}} (e.g., go 1.24.2). - This ensures the automation updates only the go directive without modifying module dependencies, aligning with Kubernetes' `go.mod` behavior. **Impact:** - Running make `update-golang-version` now updates the go directive (e.g., from go 1.22.3 to go 1.24.2) without unintended dependency version bumps. - Tested by setting go 1.22.3 in go.mod, running go mod tidy and make update-golang-version, and verifying only the go directive and toolchain changed. fixes: kubernetes#20773

…p failes

medyagh · 2025-05-24T00:18:08Z

clean up duplicates

minikube-bot · 2025-05-24T06:56:00Z

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2025-05-27T08:44:46Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20770) |
+----------------+----------+---------------------+
| minikube start | 45.3s    | 45.3s               |
| enable ingress | 15.6s    | 15.7s               |
+----------------+----------+---------------------+

Times for minikube start: 48.0s 43.7s 42.5s 48.1s 44.3s
Times for minikube (PR 20770) start: 47.1s 44.9s 42.6s 44.6s 47.3s

Times for minikube (PR 20770) ingress: 15.6s 15.1s 16.7s 15.1s 16.2s
Times for minikube ingress: 15.7s 16.1s 15.6s 14.6s 16.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20770) |
+----------------+----------+---------------------+
| minikube start | 26.3s    | 25.1s               |
| enable ingress | 13.0s    | 12.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 20770) start: 24.5s 27.2s 24.2s 26.2s 23.3s
Times for minikube start: 25.1s 26.7s 27.2s 26.6s 26.0s

Times for minikube ingress: 12.9s 13.4s 13.3s 12.3s 12.8s
Times for minikube (PR 20770) ingress: 12.8s 12.8s 12.4s 13.3s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20770) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 22.5s               |
| enable ingress | 35.9s    | 34.0s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 21.4s 23.8s 24.8s 23.4s
Times for minikube (PR 20770) start: 22.3s 22.5s 25.2s 21.3s 21.1s

Times for minikube ingress: 39.9s 22.8s 39.1s 38.8s 38.8s
Times for minikube (PR 20770) ingress: 38.8s 38.8s 30.8s 22.8s 38.8s

prezha · 2025-05-27T20:19:03Z

looks like we're good here now - ie, no more kvm driver tests timeouts in few iterations
most test errors we still see (generally, not just for kvm) are due to docker's rate limiting
extracting & moving the fix to a separate pr: #20852, as we would probably want to bump go to v1.24.3 next, for which we have yet another pr: #20827

Update go from 1.24.0 to 1.24.2

949e62b

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2025

k8s-ci-robot requested a review from ComradeProgrammer May 15, 2025 20:26

k8s-ci-robot requested a review from spowelljr May 15, 2025 20:26

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2025

fix go.hash file and bump go verion in go.mod to 1.24.2

b0dc298

Updating kicbase image to v0.0.46-1747342779-20770

98ed416

nirs reviewed May 16, 2025

View reviewed changes

Updating ISO to v1.35.0-1747352413-20770

5fc9621

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2025

medyagh mentioned this pull request May 16, 2025

make automation not to bump golang patch version in go.mod #20773

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2025

Updating ISO to v1.35.0-1747425629-20770

1e43fc2