Skip to content

chore(test): use make commands in upgrade-test.yml #12857

Open
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/upgrade-test-make-commands
Open

chore(test): use make commands in upgrade-test.yml #12857
puwun wants to merge 1 commit intokubeflow:masterfrom
puwun:chore/upgrade-test-make-commands

Conversation

@puwun
Copy link
Contributor

@puwun puwun commented Feb 19, 2026

Description of your changes:

  • Added get-last-release-tag, deploy-last-release, and prepare-upgrade make targets
  • Updated upgrade-test.yml to use make commands instead of inline shell commands

Fixes: #11704

Checklist:

Copilot AI review requested due to automatic review settings February 19, 2026 18:37
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

Hi @puwun. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the upgrade test GitHub Actions workflow to call reusable Makefile targets instead of duplicating inline shell commands, aligning with issue #11704.

Changes:

  • Added Makefile targets to fetch the latest release tag, deploy the last release, and run upgrade-prep tests.
  • Updated .github/workflows/upgrade-test.yml to call the new make targets.
  • Expanded workflow path filters to rerun when the Makefile changes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Makefile Adds new upgrade-test helper targets used by CI workflow.
.github/workflows/upgrade-test.yml Switches inline shell to make targets and updates path triggers.

Signed-off-by: Pavan More <pavansmore05@gmail.com>
@puwun puwun force-pushed the chore/upgrade-test-make-commands branch from a9902c0 to dd2c479 Compare February 20, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(<test>): Use make commands in https://github.com/kubeflow/pipelines/blob/master/.github/workflows/upgrade-test.yml

2 participants