chore(test): use make commands in upgrade-test.yml #12857
chore(test): use make commands in upgrade-test.yml #12857puwun wants to merge 1 commit intokubeflow:masterfrom
upgrade-test.yml #12857Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @puwun. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Pull request overview
Refactors the upgrade test GitHub Actions workflow to call reusable Makefile targets instead of duplicating inline shell commands, aligning with issue #11704.
Changes:
- Added Makefile targets to fetch the latest release tag, deploy the last release, and run upgrade-prep tests.
- Updated
.github/workflows/upgrade-test.ymlto call the newmaketargets. - Expanded workflow path filters to rerun when the Makefile changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Makefile | Adds new upgrade-test helper targets used by CI workflow. |
| .github/workflows/upgrade-test.yml | Switches inline shell to make targets and updates path triggers. |
Signed-off-by: Pavan More <pavansmore05@gmail.com>
a9902c0 to
dd2c479
Compare
Description of your changes:
get-last-release-tag,deploy-last-release, andprepare-upgrademake targetsupgrade-test.ymlto use make commands instead of inline shell commandsFixes: #11704
Checklist: