Skip to content

chore(angular): upgrade to official 18 release #29571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 30, 2024

Issue number: internal


What is the current behavior?

Angular 18 test app was using an RC.

What is the new behavior?

  • Updated to the official release.
  • Removed the --legacy-peer-deps that is no longer needed

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 7:40pm

@github-actions github-actions bot added the package: angular @ionic/angular package label May 30, 2024
@thetaPC thetaPC marked this pull request as ready for review May 30, 2024 19:49
@thetaPC thetaPC requested a review from a team as a code owner May 30, 2024 19:49
@thetaPC thetaPC requested a review from gnbm May 30, 2024 19:49
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking care of this!

@thetaPC thetaPC added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit b138229 May 31, 2024
50 checks passed
@thetaPC thetaPC deleted the angular-18-official branch May 31, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants