Skip to content

Commit b138229

Browse files
authored
chore(angular): upgrade to official 18 release (#29571)
Issue number: internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Angular 18 test app was using an RC. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated to the official release. - Removed the `--legacy-peer-deps` that is no longer needed ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> N/A
1 parent 4bb19d0 commit b138229

File tree

4 files changed

+2284
-2073
lines changed

4 files changed

+2284
-2073
lines changed

.github/workflows/actions/test-angular-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ runs:
2929
shell: bash
3030
working-directory: ./packages/angular/test
3131
- name: Install Dependencies
32-
run: npm install --legacy-peer-deps # TODO(FW-6227): Remove legacy-peer-deps flag
32+
run: npm install
3333
shell: bash
3434
working-directory: ./packages/angular/test/build/${{ inputs.app }}
3535
- name: Sync Built Changes

0 commit comments

Comments
 (0)