Skip to content

Commit 9651ebe

Browse files
Address review comments
1 parent 15ad8e0 commit 9651ebe

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.github/workflows/third-party-benchmarks.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,31 +114,31 @@ jobs:
114114
pip install sglang/python[srt_xpu]
115115
116116
- name: Run SGLANG attention prefill stage benchmark
117-
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'prefill_attention_benchmark.py') }}
117+
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
118118
run: |
119119
cd benchmarks/third_party/sglang
120120
python prefill_attention_benchmark.py --reports $REPORTS
121121
122122
source ../../../scripts/capture-hw-details.sh
123-
python ../../../scripts/build_report.py $REPORTS/prefill-attn-performance.csv $REPORTS/attn-prefill-triton-report.csv --benchmark sglang-prefill-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
123+
python ../../triton_kernels_benchmark/build_report.py $REPORTS/prefill-attn-performance.csv $REPORTS/attn-prefill-triton-report.csv --benchmark sglang-prefill-attn --compiler triton --param_cols "B,SEQ_LENS,H_Q,H_KV,D,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
124124
125125
- name: Run SGLANG attention decode stage benchmark
126-
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'decode_attention_benchmark.py') }}
126+
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
127127
run: |
128128
cd benchmarks/third_party/sglang
129129
python decode_attention_benchmark.py --reports $REPORTS
130130
131131
source ../../../scripts/capture-hw-details.sh
132-
python ../../../scripts/build_report.py $REPORTS/decode-attn-performance.csv $REPORTS/attn-decode-triton-report.csv --benchmark sglang-decode-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
132+
python ../../triton_kernels_benchmark/build_report.py $REPORTS/decode-attn-performance.csv $REPORTS/attn-decode-triton-report.csv --benchmark sglang-decode-attn --compiler triton --param_cols "B,SEQ_LENS,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
133133
134134
- name: Run SGLANG attention append stage benchmark
135-
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'decode_attention_benchmark.py') }}
135+
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
136136
run: |
137137
cd benchmarks/third_party/sglang
138138
python extended_attention_benchmark.py --reports $REPORTS
139139
140140
source ../../../scripts/capture-hw-details.sh
141-
python ../../../scripts/build_report.py $REPORTS/extended-attn-performance.csv $REPORTS/attn-append-triton-report.csv --benchmark sglang-extended-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
141+
python ../../triton_kernels_benchmark/build_report.py $REPORTS/extended-attn-performance.csv $REPORTS/attn-append-triton-report.csv --benchmark sglang-extended-attn --compiler triton --param_cols "B,SEQ_LENS,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
142142
143143
- name: Upload benchmark reports
144144
if: ${{ steps.install.outcome == 'success' && !cancelled() }}

benchmarks/triton_kernels_benchmark/build_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def build_report(args: PassedArgs):
6969
df[p] = df[p].astype(int)
7070
df_results["params"] = [json.dumps(j) for j in df[[*param_cols, "MASK"]].to_dict("records")]
7171
else:
72-
df_results["params"] = [json.dumps(j) for j in df[param_cols].astype(int).to_dict("records")]
72+
df_results["params"] = [json.dumps(j) for j in df[param_cols].astype(str).to_dict("records")]
7373
df_results["tflops"] = df[args.tflops_col]
7474
if hbm_col is not None:
7575
df_results["hbm_gbs"] = df[hbm_col]

0 commit comments

Comments
 (0)