Skip to content

Commit 7d4d837

Browse files
Address review comments
Remove sglang from tests
1 parent ec87c1b commit 7d4d837

File tree

4 files changed

+12
-246
lines changed

4 files changed

+12
-246
lines changed

.github/pins/sglang.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

.github/workflows/third-party-benchmarks.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -110,35 +110,36 @@ jobs:
110110
111111
- name: Install SGLANG
112112
run: |
113-
SGLANG_PIN="$(<.github/pins/sglang.txt)"
114-
pip install sglang==$SGLANG_PIN
113+
git clone https://github.com/sgl-project/sglang.git
114+
cd sglang/python
115+
pip install .
115116
116117
- name: Run SGLANG attention prefill stage benchmark
117118
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'prefill_attention_benchmark.py') }}
118119
run: |
119120
cd benchmarks/third_party/sglang
120-
python prefill_attention_benchmark --reports $REPORTS
121+
python prefill_attention_benchmark.py --reports $REPORTS
121122
122-
source ../../scripts/capture-hw-details.sh
123-
python ../../scripts/build_report.py $REPORTS/prefill-attn-performance.csv $REPORTS/attn-prefill-triton-report.csv --benchmark attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
123+
source ../../../scripts/capture-hw-details.sh
124+
python ../../../scripts/build_report.py $REPORTS/prefill-attn-performance.csv $REPORTS/attn-prefill-triton-report.csv --benchmark sglang-prefill-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
124125
125126
- name: Run SGLANG attention decode stage benchmark
126127
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'decode_attention_benchmark.py') }}
127128
run: |
128129
cd benchmarks/third_party/sglang
129-
python decode_attention_benchmark --reports $REPORTS
130+
python decode_attention_benchmark.py --reports $REPORTS
130131
131-
source ../../scripts/capture-hw-details.sh
132-
python ../../scripts/build_report.py $REPORTS/decode-attn-performance.csv $REPORTS/attn-decode-triton-report.csv --benchmark attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
132+
source ../../../scripts/capture-hw-details.sh
133+
python ../../../scripts/build_report.py $REPORTS/decode-attn-performance.csv $REPORTS/attn-decode-triton-report.csv --benchmark sglang-decode-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
133134
134135
- name: Run SGLANG attention append stage benchmark
135136
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'decode_attention_benchmark.py') }}
136137
run: |
137138
cd benchmarks/third_party/sglang
138-
python extended_attention_benchmark --reports $REPORTS
139+
python extended_attention_benchmark.py --reports $REPORTS
139140
140-
source ../../scripts/capture-hw-details.sh
141-
python ../../scripts/build_report.py $REPORTS/extended-attn-performance.csv $REPORTS/attn-append-triton-report.csv --benchmark attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
141+
source ../../../scripts/capture-hw-details.sh
142+
python ../../../scripts/build_report.py $REPORTS/extended-attn-performance.csv $REPORTS/attn-append-triton-report.csv --benchmark sglang-extended-attn --compiler triton --param_cols "B,N_CTX,H_Q,H_KV,D" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
142143
143144
- name: Upload benchmark reports
144145
if: ${{ steps.install.outcome == 'success' && !cancelled() }}

.github/workflows/third-party-tests.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -96,19 +96,6 @@ jobs:
9696
9797
pytest Liger-Kernel/test/
9898
99-
- name: Run SGLANG tests
100-
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
101-
run: |
102-
pip install transformers pandas pytest openai
103-
104-
SGLANG_PIN="$(<.github/pins/sglang.txt)"
105-
pip install datasets decord sglang==$SGLANG_PIN
106-
git clone https://github.com/sgl-project/sglang.git --branch $SGLANG_PIN --single-branch
107-
108-
cd sglang
109-
git apply ../benchmarks/third_party/sglang/sglang.patch
110-
pytest sglang/test/srt/test_triton_attention_kernels.py
111-
11299
- name: Upload test report
113100
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
114101
uses: actions/upload-artifact@v4

benchmarks/third_party/sglang/sglang.patch

Lines changed: 0 additions & 221 deletions
This file was deleted.

0 commit comments

Comments
 (0)