Skip to content

HHH-19464 storing a binary data into blob on oracle cutting off its content #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,6 @@ public static byte[] extractBytes(InputStream inputStream, long start, int lengt
break;
}
outputStream.write( buffer, 0, amountRead );
if ( amountRead < buffer.length ) {
// we have read up to the end of stream
break;
}
bytesRead += amountRead;
if ( bytesRead >= length ) {
break;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
/*
* SPDX-License-Identifier: Apache-2.0
* Copyright Red Hat Inc. and Hibernate Authors
*/
package org.hibernate.orm.test.lob;

import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import jakarta.persistence.Lob;
import org.hibernate.engine.jdbc.env.internal.NonContextualLobCreator;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.JiraKey;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
import org.junit.jupiter.api.Test;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.sql.Blob;
import java.sql.SQLException;
import java.util.Random;
import java.util.zip.GZIPInputStream;
import java.util.zip.GZIPOutputStream;

import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;

@DomainModel(annotatedClasses = InflaterInputStreamBlobTest.TestEntity.class)
@SessionFactory
@JiraKey("HHH-19464")
class InflaterInputStreamBlobTest {

private static final int RANDOM_SIZE = 32000;

@Test
void hibernate_blob_streaming(SessionFactoryScope scope) throws Exception {
final var randomBytes = getRandomBytes();
final var outputStream = new ByteArrayOutputStream();
try (var zipOutputStream = new GZIPOutputStream( outputStream )) {
zipOutputStream.write( randomBytes );
}

long size = randomBytes.length;
scope.inTransaction( entityManager -> {
try {
InputStream is = new GZIPInputStream( new ByteArrayInputStream( outputStream.toByteArray() ) );
Blob blob = NonContextualLobCreator.INSTANCE.wrap(
NonContextualLobCreator.INSTANCE.createBlob( is, size )
);
TestEntity e = new TestEntity();
e.setId( 1L );
e.setData( blob );

entityManager.persist( e );
}
catch (IOException e) {
throw new RuntimeException( e );
}
}
);

scope.inStatelessSession( session -> {
final var entity = session.get( TestEntity.class, 1L );
try {
final var blob = entity.getData();
assertEquals( size, blob.length() );
assertArrayEquals( randomBytes, blob.getBytes( 1L, (int) blob.length() ) );
}
catch (SQLException e) {
throw new RuntimeException( e );
}
} );
}

private static byte[] getRandomBytes() {
final var bytes = new byte[RANDOM_SIZE];
new Random().nextBytes( bytes );

Check warning

Code scanning / CodeQL

Random used only once Warning test

Random object created and used only once.
return bytes;
}

@Entity
public static class TestEntity {

@Id
Long id;

@Lob
Blob data;

public Long getId() {
return id;
}

public void setId(Long id) {
this.id = id;
}

public Blob getData() {
return data;
}

public InputStream getInputStream() {
try {
return data.getBinaryStream();
}
catch (SQLException e) {
throw new IllegalArgumentException( "Could not obtain requested input stream", e );
}
}

public void setData(Blob data) {
this.data = data;
}
}
}