HHH-19464 storing a binary data into blob on oracle cutting off its content #10160
Conversation
cigaly
changed the title
|
|
||
| @Test | ||
| void hibernate_blob_streaming(SessionFactoryScope scope) throws Exception { | ||
| final var zipFilePath = getClass().getClassLoader().getResource( "org/hibernate/orm/test/lob/JarFileEntryBlobTest.zip" ); |
There was a problem hiding this comment.
Not great (and potentially dangerous) to have a zip file just for testing purposes. Could we reproduce the error with a simple byte-array and org.hibernate.engine.jdbc.proxy.BlobProxy?
There was a problem hiding this comment.
Any stream that will always read complete buffer (with exception of last read) will not expose this problem. java.util.zip.InflaterInputStream can return less bytes before reading next bytes to be deflated.
Possible way to avoid zip file in resources is to create it temporary on th fly.
To avoid this GZIPOutputStream can be used to deflate (random) bytes, then GZIPInputStream can be used to create blob.
…]) returns less bytes than buffer length
cigaly
force-pushed
the
HHH-19464-Storing_a_binary_data_into_BLOB_on_Oracle_cutting_off_its_content
branch
from
a69a8b7 to
baad677
Compare
cigaly
force-pushed
the
HHH-19464-Storing_a_binary_data_into_BLOB_on_Oracle_cutting_off_its_content
branch
from
baad677 to
0add274
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| private static byte[] getRandomBytes() { | ||
| final var bytes = new byte[RANDOM_SIZE]; | ||
| new Random().nextBytes( bytes ); |
Check warning
Code scanning / CodeQL
Random used only once Warning test
Jira issue HHH-19464
In
org.hibernate.type.descriptor.java.DataHelper#extractBytes(java.io.InputStream, long, int)assumption thatjava.io.InputStream#read(byte[])reached EOF when number of bytes read is less than size of buffer is not correct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.