Skip to content

deps: bump node to v22.16.0 #93080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 16, 2025
Merged

deps: bump node to v22.16.0 #93080

merged 19 commits into from
Jun 16, 2025
+75 −76

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 6, 2025 •
edited by natemoo-re
Loading

@JonasBa JonasBa requested review from a team as code owners June 6, 2025 22:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@JonasBa JonasBa requested a review from a team June 6, 2025 22:27
@JonasBa JonasBa mentioned this pull request Jun 6, 2025
Merged
@JonasBa
Copy link
Member Author

JonasBa commented Jun 6, 2025 •
edited
Loading

@joshuarli what is the process for updating the mirror and shasum? I've updated the shasum to match the files available from node, but I'm currently getting a 404 from our mirror

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

joshuarli
joshuarli approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've updated this PR to use .node-version!

joshuarli
joshuarli reviewed Jun 11, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #93080       +/-   ##
===========================================
+ Coverage   46.37%   88.08%   +41.70%     
===========================================
  Files       10309    10330       +21     
  Lines      594899   595883      +984     
  Branches    23130    23126        -4     
===========================================
+ Hits       275905   524899   +248994     
+ Misses     318501    70491   -248010     
  Partials      493      493

@natemoo-re
Copy link
Member

I'm working on the CI failures—just a resolution issue with a node-style specifier in the rspack config.

@scttcper
Copy link
Member

oh nvm i get it, vercel would need the unflagged transpile. got it

@natemoo-re
Copy link
Member

natemoo-re commented Jun 11, 2025 •
edited
Loading

True! Just being cautious of the official guidance since bugs on Current releases aren't unheard of.

Production applications should only use Active LTS or Maintenance LTS releases.

And yeah, Vercel doesn't expose v24 yet for that reason.

@JonasBa
Copy link
Member Author

JonasBa commented Jun 16, 2025

I've fixed the related build issues in #93392. If someone can review them, we should be able to merge this in, and finally upgrade to 22.16

@JonasBa
build: run rspack in ESM with Node v22.16 (#93392)
976d002 
Fixes build issue in Node v22.16.0 by running rspack in ESM mode.
@JonasBa JonasBa requested a review from a team as a code owner June 16, 2025 17:04
@joshuarli joshuarli merged commit 4df68a9 into master Jun 16, 2025
69 checks passed
@joshuarli joshuarli deleted the jb/node/24 branch June 16, 2025 18:59
@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 16, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 0aeb212

getsentry-bot added a commit that referenced this pull request Jun 16, 2025
@getsentry-bot @asottile-sentry
Revert "deps: bump node to v22.16.0 (#93080)"
0aeb212 
This reverts commit 4df68a9.

Co-authored-by: asottile-sentry <[email protected]>
JonasBa added a commit that referenced this pull request Jun 16, 2025
@JonasBa
Reapply "deps: bump node to v22.16.0 (#93080)"
d95f7ab 
This reverts commit 0aeb212.
joshuarli pushed a commit that referenced this pull request Jun 16, 2025
@JonasBa
Reapply "deps: bump node to v22.16.0 (#93080)" (#93645)
97aa01e 
Reapply node version bump, but preserve .volta.json so we can maintain
backcompat with getsentry
getsentry-bot added a commit that referenced this pull request Jun 16, 2025
@getsentry-bot @asottile-sentry
Revert "Reapply "deps: bump node to v22.16.0 (#93080)" (#93645)"
f89d26e 
This reverts commit 97aa01e.

Co-authored-by: asottile-sentry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarli joshuarli joshuarli approved these changes

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JonasBa @natemoo-re @joshuarli @scttcper @getsentry-bot @evanpurkhiser @asottile-sentry