Merge remote-tracking branch 'origin' into jb/node/24

Author: joshuarli

src/sentry/api/serializers/models/release.py

@@ -25,6 +25,8 @@
 from sentry.models.releases.release_project import ReleaseProject
 from sentry.release_health.base import ReleaseHealthOverview
 from sentry.users.api.serializers.user import UserSerializerResponse
+from sentry.users.models.user import User
+from sentry.users.services.user.model import RpcUser
 from sentry.users.services.user.serial import serialize_generic_user
 from sentry.users.services.user.service import user_service
 from sentry.utils import metrics
@@ -111,7 +113,13 @@ def _expose_current_project_meta(current_project_meta):
     return rv
 
 
-def _get_authors_metadata(item_list, user):
+class _AuthorList(TypedDict):
+    authors: list[Author]
+
+
+def _get_authors_metadata(
+    item_list: list[Release], user: User | RpcUser | AnonymousUser
+) -> dict[Release, _AuthorList]:
     """
     Returns a dictionary of release_id => authors metadata,
     where each commit metadata dict contains an array of
@@ -126,7 +134,8 @@ def _get_authors_metadata(item_list, user):
     """
     author_ids = set()
     for obj in item_list:
-        author_ids.update(obj.authors)
+        if obj.authors is not None:
+            author_ids.update(obj.authors)
 
     if author_ids:
         authors = list(CommitAuthor.objects.filter(id__in=author_ids))
@@ -144,18 +153,17 @@ def _get_authors_metadata(item_list, user):
     else:
         users_by_author = {}
 
-    result = {}
+    result: dict[Release, _AuthorList] = {}
     for item in item_list:
         item_authors = []
         seen_authors = set()
-        for user in (users_by_author.get(a) for a in item.authors):
-            if user and user["email"] not in seen_authors:
-                seen_authors.add(user["email"])
-                item_authors.append(user)
+        if item.authors is not None:
+            for user_resp in (users_by_author.get(a) for a in item.authors):
+                if user_resp and user_resp["email"] not in seen_authors:
+                    seen_authors.add(user_resp["email"])
+                    item_authors.append(user_resp)
 
-        result[item] = {
-            "authors": item_authors,
-        }
+        result[item] = {"authors": item_authors}
     return result
 
 
@@ -226,7 +234,9 @@ class NonMappableUser(TypedDict):
 
 
 def get_users_for_authors(
-    organization_id: int, authors: list[CommitAuthor], user=None
+    organization_id: int,
+    authors: list[CommitAuthor],
+    user: User | AnonymousUser | RpcUser | None = None,
 ) -> Mapping[str, Author]:
     """
     Returns a dictionary of author_id => user, if a Sentry

static/app/views/issueDetails/streamline/sidebar/seerDrawer.tsx

@@ -6,7 +6,6 @@ import Feature from 'sentry/components/acl/feature';
 import {Breadcrumbs as NavigationBreadcrumbs} from 'sentry/components/breadcrumbs';
 import {Flex} from 'sentry/components/container/flex';
 import {ProjectAvatar} from 'sentry/components/core/avatar/projectAvatar';
-import {FeatureBadge} from 'sentry/components/core/badge/featureBadge';
 import {Button} from 'sentry/components/core/button';
 import {ButtonBar} from 'sentry/components/core/button/buttonBar';
 import {LinkButton} from 'sentry/components/core/button/linkButton';
@@ -215,16 +214,6 @@ export function SeerDrawer({group, project, event}: SeerDrawerProps) {
         <SeerDrawerNavigator>
           <Flex align="center" gap={space(1)}>
             <Header>{t('Seer')}</Header>
-            <FeatureBadge
-              type="beta"
-              tooltipProps={{
-                title: tct(
-                  'This feature is in beta. Try it out and let us know your feedback at [email:[email protected]].',
-                  {email: <a href="mailto:[email protected]" />}
-                ),
-                isHoverable: true,
-              }}
-            />
             <QuestionTooltip
               isHoverable
               title={

tests/sentry/api/serializers/test_release.py

@@ -130,6 +130,14 @@ def test_simple(self):
             == current_project_meta["last_release_version"]
         )
 
+    def test_authors_is_none(self):
+        release = Release.objects.create(
+            organization_id=self.organization.id, version="1", authors=None
+        )
+        release.add_project(self.project)
+        result = serialize(release, self.user)
+        assert result["authors"] == []
+
     def test_mobile_version(self):
         user = self.create_user()
         project = self.create_project()