Closed
Conversation
Member
Author
|
@ruchamahabal review please! Will do for the older versions if this is approved. |
asmitahase
force-pushed
the
patch-workflow
branch
from
2bb28b8 to
0f8a268
Compare
ankush
reviewed
May 16, 2025
Comment on lines
+108
to
+109
| wget https://erpnext.com/files/v13-erpnext.sql.gz | ||
| bench --site test_site --force restore ~/frappe-bench/v13-erpnext.sql.gz |
Member
There was a problem hiding this comment.
This isn't sufficient IMO. Both of the current patch test backups have some Frappe/ERPNext specific test data. They're woefully inadequate, but at least it's there. Empty tables will ignore a lot possible failure modes that can happen during schema migrations.
Maybe create a new v14 site with some dummy data and store it somewhere?
Member
Author
There was a problem hiding this comment.
I thought of that initially but then it leaves out sites updating from v13?
Member
There was a problem hiding this comment.
v13 is EOL since ~1.5 years now. So IMO it's better to expand "coverage" of code that gets tested vs. coverage of tested versions.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should catch migration failures before they end up in the release
to-do
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/