frappe.exceptions.ValidationError: The limit has not set for the user type Employee Self Service in the site config file.

[mohsinalimat]

Information about bug

Executing hrms.patches.v15_0.add_leave_type_permission_for_ess in xtz.com (_557ff2289e4dbcf1)
Failed to execute patch
Traceback with variables (most recent call last):
File "apps/frappe/frappe/modules/patch_handler.py", line 62, in run_patch
if not run_single(patchmodule=patch):
patch = 'hrms.patches.v15_0.add_leave_type_permission_for_ess'
skip_failing = True
File "apps/frappe/frappe/modules/patch_handler.py", line 152, in run_single
return execute_patch(patchmodule, method, methodargs)
patchmodule = 'hrms.patches.v15_0.add_leave_type_permission_for_ess'
method = None
methodargs = None
force = False
conf = frappe.utils.local.LocalProxy{'background_workers': 1, 'dns_multitenant': True, 'file_watcher_port': 6787, 'frappe_user': 'frappe', 'gunicorn_workers': 5, 'live_reload': True, 'maintenance_mode': 1, 'pause_scheduler': 1, 'rebase_on_pull': False, 'redis_cache': 'redis://127.0.0.1:13000', 'redis_queue': 'redis://127.0.0.1:11000', 'redis_socketio': 'redis://127.0.0.1:13000', 'restart_supervisor_on_update': True, 'restart_systemd_on_update': False, 'serve_default_site': True, 'shallow_clone': True, 'socketio_port': 9000, 'use_redis_auth': False, 'webserver_port': 8000, 'db_name': '_557ff2289e4dbcf1', 'db_password': 'bV8ok9eiert41xDB', 'db_type': 'mariadb', 'db_user': '_557ff2289e4dbcf1', 'user_type_limits': {'System User': {'limit': 5000, 'window': 3600}, 'Website User': {'limit': 1000, 'window': 3600}, 'Employee Self Service': {'limit': 2000, 'window': 3600}}, 'db_socket': None, 'db_host': '127.0.0.1', 'db_port': 3306, 'developer_mode': 0}
File "apps/frappe/frappe/modules/patch_handler.py", line 188, in execute_patch
_patch()
patchmodule = 'hrms.patches.v15_0.add_leave_type_permission_for_ess'
method = None
methodargs = None
has_patch_file = True
patch = 'hrms.patches.v15_0.add_leave_type_permission_for_ess.execute'
docstring = ''
_patch = <function execute at 0x755fe44c5dd0>
start_time = 3943762.35573335
File "apps/hrms/hrms/patches/v15_0/add_leave_type_permission_for_ess.py", line 18, in execute
doc.save()
doc = User Type (Employee Self Service)
existing = {'Employee Benefit Application', 'Employee Tax Exemption Proof Submission', 'Employee Referral', 'Training Feedback', 'Training Program', 'Employee', 'Holiday List', 'Salary Slip', 'Leave Application', 'Travel Request', 'Shift Request', 'Employee Checkin', 'Employee Grievance', 'Employee Advance', 'Expense Claim Type', 'Company', 'Employee Tax Exemption Declaration', 'Compensatory Leave Request', 'Timesheet', 'Expense Claim', 'Attendance Request'}
File "apps/frappe/frappe/model/document.py", line 518, in save
return self._save(*args, **kwargs)
self = User Type (Employee Self Service)
args = ()
kwargs = {}
File "apps/frappe/frappe/model/document.py", line 572, in _save
self.run_post_save_methods()
self = User Type (Employee Self Service)
ignore_permissions = None
ignore_version = None
File "apps/frappe/frappe/model/document.py", line 1375, in run_post_save_methods
self.run_method("on_update")
self = User Type (Employee Self Service)
File "apps/frappe/frappe/model/document.py", line 1181, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
self = User Type (Employee Self Service)
method = 'on_update'
args = ()
kwargs = {}
fn = <function Document.run_method..fn at 0x755fe43fe560>
File "apps/frappe/frappe/model/document.py", line 1578, in composer
return composed(self, method, args, **kwargs)
self = User Type (Employee Self Service)
args = ()
kwargs = {}
hooks = [<function clear_doctype_notifications at 0x755ff0308250>, <function process_workflow_actions at 0x755fe42bb8a0>, <function attach_files_to_document at 0x755ff1be9640>, <function apply at 0x755fe4336820>, <function update_due_date at 0x755fe43368d0>, <function apply_permissions_for_non_standard_user_type at 0x755fe4154300>, <function make_perm_log at 0x755fe41543b0>, <function update_doc_index at 0x755fe417c5c0>]
method = 'on_update'
doc_events = {'': {'on_update': ['frappe.desk.notifications.clear_doctype_notifications', 'frappe.workflow.doctype.workflow_action.workflow_action.process_workflow_actions', 'frappe.core.doctype.file.utils.attach_files_to_document', 'frappe.automation.doctype.assignment_rule.assignment_rule.apply', 'frappe.automation.doctype.assignment_rule.assignment_rule.update_due_date', 'frappe.core.doctype.user_type.user_type.apply_permissions_for_non_standard_user_type', 'frappe.core.doctype.permission_log.permission_log.make_perm_log', 'frappe.search.sqlite_search.update_doc_index'], 'after_rename': ['frappe.desk.notifications.clear_doctype_notifications'], 'on_cancel': ['frappe.desk.notifications.clear_doctype_n...'Price List': {'validate': ['webshop.webshop.crud_events.price_list.check_impact_on_cart.execute']}, 'Tax Rule': {'validate': ['webshop.webshop.crud_events.tax_rule.validate_use_for_cart.execute']}, 'Patient': {'after_insert': ['healthcare.regional.india.abdm.utils.set_consent_attachment_details']}}
handler = 'frappe.search.sqlite_search.update_doc_index'
composed = <function Document.hook..compose..runner at 0x755fe42950c0>
compose = <function Document.hook..compose at 0x755fe4294f60>
f = <function Document.run_method..fn at 0x755fe43fe560>
File "apps/frappe/frappe/model/document.py", line 1556, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
self = User Type (Employee Self Service)
method = 'on_update'
args = ()
kwargs = {}
add_to_return_value = <function Document.hook..add_to_return_value at 0x755fe4294bf0>
fn = <function Document.run_method..fn at 0x755fe43fe560>
hooks = (<function clear_doctype_notifications at 0x755ff0308250>, <function process_workflow_actions at 0x755fe42bb8a0>, <function attach_files_to_document at 0x755ff1be9640>, <function apply at 0x755fe4336820>, <function update_due_date at 0x755fe43368d0>, <function apply_permissions_for_non_standard_user_type at 0x755fe4154300>, <function make_perm_log at 0x755fe41543b0>, <function update_doc_index at 0x755fe417c5c0>)
File "apps/frappe/frappe/model/document.py", line 1178, in fn
return method_object(*args, **kwargs)
self = User Type (Employee Self Service)
args = ()
kwargs = {}
method_object = <bound method UserType.on_update of <UserType: doctype=User Type Employee Self Service>>
method = 'on_update'
File "apps/frappe/frappe/core/doctype/user_type/user_type.py", line 51, in on_update
self.validate_document_type_limit()
self = User Type (Employee Self Service)
File "apps/frappe/frappe/core/doctype/user_type/user_type.py", line 88, in validate_document_type_limit
frappe.throw(
self = User Type (Employee Self Service)
limit = None
File "apps/frappe/frappe/utils/messages.py", line 148, in throw
msgprint(
msg = 'The limit has not set for the user type Employee Self Service in the site config file.'
exc = frappe.exceptions.ValidationError
title = 'Set Limit'
is_minimizable = False
wide = False
as_list = False
primary_action = None
File "apps/frappe/frappe/utils/messages.py", line 109, in msgprint
_raise_exception()
msg = 'The limit has not set for the user type Employee Self Service in the site config file.'
title = 'Set Limit'
raise_exception = frappe.exceptions.ValidationError
as_table = False
as_list = False
indicator = 'red'
alert = False
primary_action = None
is_minimizable = False
wide = False
realtime = False
_raise_exception = <function msgprint.._raise_exception at 0x755fe4294b40>
inspect = <module 'inspect' from '/usr/lib/python3.14/inspect.py'>
out = {'message': 'The limit has not set for the user type Employee Self Service in the site config file.', 'as_table': False, 'title': 'Set Limit', 'indicator': 'red', 'raise_exception': 1, '__frappe_exc_id': '362e4dd094f7c9989a078fa880f875106fd5d9c953595563bdc4a788'}
File "apps/frappe/frappe/utils/messages.py", line 58, in _raise_exception
raise exc
exc = The limit has not set for the user type Employee Self Service in the site config file.
inspect = <module 'inspect' from '/usr/lib/python3.14/inspect.py'>
msg = 'The limit has not set for the user type Employee Self Service in the site config file.'
out = {'message': 'The limit has not set for the user type Employee Self Service in the site config file.', 'as_table': False, 'title': 'Set Limit', 'indicator': 'red', 'raise_exception': 1, '__frappe_exc_id': '362e4dd094f7c9989a078fa880f875106fd5d9c953595563bdc4a788'}
raise_exception = frappe.exceptions.ValidationError
frappe.exceptions.ValidationError: The limit has not set for the user type Employee Self Service in the site config file.

Module

other

Version

{
	"frappe": "16.5.0",
	"erpnext": "16.4.0",
	"hrms": "16.3.1",
	"non_profit": "0.0.1",
	"india_compliance": "16.0.0-dev",
	"payments": "0.0.1",
	"webshop": "0.0.1",
	"eps": "0.0.1",
	"offsite_backups": "0.0.1",
	"healthcare": "16.0.2"
}

Installation method

None

Relevant log output / Stack trace / Full Error Message.

Already config in site config file.

Code of Conduct

• I agree to follow this project's Code of Conduct

[asmitahase]

This cannot get here soon enough #3119
Apologies for this, was the user type limit manually removed from site config?

[mohsinalimat]

No. It is already there.

{ "user_type_limits": { "Employee Self Service": { "limit": 1000, "window": 3600 } } }

[asmitahase]

The object is different

[asmitahase]

As a quick fix, can you add "user_type_doctype_limit": { "employee_self_service": 1000 } to the file and retry migrate

[mohsinalimat]

As a quick fix, can you add "user_type_doctype_limit": { "employee_self_service": 1000 } to the file and retry migrate

Ok let me check with this

[mohsinalimat]

As a quick fix, can you add "user_type_doctype_limit": { "employee_self_service": 1000 } to the file and retry migrate

Done, thanks.

[mohsinalimat]

@asmitahase Why we have to write hard code in site config json file?

[asmitahase]

Not hard coding, this config should have existed with the correct structure, we'll fix the patch, I was just checking how { "user_type_limits": { "Employee Self Service": { "limit": 1000, "window": 3600 } } } made it to the config file instead of the correct structure, if it wasn't modified by you manually

[mohsinalimat]

Please check also when there no parameter in json file.

[mohsinalimat]

Not hard coding, this config should have existed with the correct structure, we'll fix the patch, I was just checking how { "user_type_limits": { "Employee Self Service": { "limit": 1000, "window": 3600 } } } made it to the config file instead of the correct structure, if it wasn't modified by you manually

Any updates on this patch?