Use correct DA transaction compression #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danyalprout please review |
karim-agha
approved these changes
May 21, 2025
|
Oh, I maybe missed it :) |
|
@danyalprout fixed |
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
4 times, most recently
from
4cb410e to
f9ec955
Compare
ferranbt
reviewed
May 22, 2025
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
be4d330 to
886a7de
Compare
|
@ferranbt @danyalprout |
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
886a7de to
4643203
Compare
danyalprout
approved these changes
May 23, 2025
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
3 times, most recently
from
6c4e43f to
6a240d7
Compare
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
6a240d7 to
25853e1
Compare
Changed revert tests a bit fmt Add txpool test Fix DA config, set it via miner Extend tests Add op-alloy-flz dependency and update related configurations - Added `op-alloy-flz` as a dependency in `Cargo.toml` and `Cargo.lock`. - Configured `op-alloy-flz` to be part of the workspace in `op-rbuilder`'s `Cargo.toml`. - Updated the `payload_builder_vanilla.rs` to utilize `op-alloy-flz` for transaction size estimation. - Enhanced test framework to include new data availability tests ensuring block size limits are respected. Add max data availability transaction and block size configuration - Introduced `max_da_tx_size` and `max_da_block_size` fields in `TestHarnessBuilder` and `OpRbuilderConfig`. - Added builder methods `with_max_da_tx_size` and `with_max_da_block_size` for setting these values. - Implemented a new test to ensure transaction size limits are respected in data availability scenarios. - Updated test module to include the new data availability test. Add cumulative_da_bytes_used accur Add da config Use correct DA transaction compression
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
25853e1 to
f0f410d
Compare
ferranbt
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Supersedes #7 and #8
Added some extra integration tests for txpool
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test