Added drop impl to clean up after tests

Changed revert tests a bit

Author: SozinM

crates/op-rbuilder/src/tests/framework/harness.rs

@@ -128,7 +128,7 @@ impl TestHarnessBuilder {
         let builder_log_path = builder.log_path.clone();
 
         Ok(TestHarness {
-            _framework: framework,
+            framework: framework,
             builder_auth_rpc_port,
             builder_http_port,
             validator_auth_rpc_port,
@@ -138,7 +138,7 @@ impl TestHarnessBuilder {
 }
 
 pub struct TestHarness {
-    _framework: IntegrationFramework,
+    framework: IntegrationFramework,
     builder_auth_rpc_port: u16,
     builder_http_port: u16,
     validator_auth_rpc_port: u16,
@@ -252,6 +252,16 @@ impl TestHarness {
     }
 }
 
+impl Drop for TestHarness {
+    fn drop(&mut self) {
+        for service in &mut self.framework.services {
+            let res = service.stop();
+            if let Err(e) = res {
+                println!("Failed to stop service: {}", e);
+            }
+        }
+    }
+}
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum TransactionStatus {
     NotFound,

crates/op-rbuilder/src/tests/framework/op.rs

@@ -149,9 +149,7 @@ impl Service for OpRbuilderConfig {
         if let Some(http_port) = self.http_port {
             cmd.arg("--http")
                 .arg("--http.port")
-                .arg(http_port.to_string())
-                .arg("--http.api")
-                .arg("eth,web3,txpool");
+                .arg(http_port.to_string());
         }
 
         if let Some(flashblocks_ws_url) = &self.flashblocks_ws_url {

crates/op-rbuilder/src/tests/vanilla/data_availability.rs

@@ -69,7 +69,7 @@ async fn data_availability_block_size_limit() -> eyre::Result<()> {
 /// We should not forget about builder transaction so we will spawn only 2 regular txs.
 #[tokio::test]
 async fn data_availability_block_fill() -> eyre::Result<()> {
-    let harness = TestHarnessBuilder::new("data_availability_tx_size_limit")
+    let harness = TestHarnessBuilder::new("data_availability_block_fill")
         .with_namespaces("admin,eth,miner")
         .build()
         .await?;

crates/op-rbuilder/src/tests/vanilla/revert.rs

@@ -13,6 +13,7 @@ use crate::{
 async fn revert_protection_monitor_transaction_gc() -> eyre::Result<()> {
     let harness = TestHarnessBuilder::new("revert_protection_monitor_transaction_gc")
         .with_revert_protection()
+        .with_namespaces("eth,web3,txpool")
         .build()
         .await?;
 
@@ -105,6 +106,7 @@ async fn revert_protection_disabled_bundle_endpoint_error() -> eyre::Result<()>
 async fn revert_protection_bundle() -> eyre::Result<()> {
     let harness = TestHarnessBuilder::new("revert_protection_bundle")
         .with_revert_protection()
+        .with_namespaces("eth,web3,txpool")
         .build()
         .await?;