Skip to content

[Dataset Quality] Wrap discover test checks in retries #221365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented May 23, 2025

Summary

This PR wraps test checks in retries to avoid checking before loading is completed.

closes #221348

@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner May 23, 2025 12:22
@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 23, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8293

[✅] x-pack/test/functional/apps/dataset_quality/config.ts: 50/50 tests passed.

see run history

@mohamedhamed-ahmed mohamedhamed-ahmed enabled auto-merge (squash) May 23, 2025 14:12
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit a2bd0a7 into elastic:main May 23, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15213115473

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Dataset quality] Failure store privileges and enablement (#220874)

Manual backport

To create the backport manually run:

node scripts/backport --pr 221365

Questions ?

Please refer to the Backport tool documentation

@mohamedhamed-ahmed
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mohamedhamed-ahmed added a commit that referenced this pull request May 28, 2025
… (#221625)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Dataset Quality] Wrap discover test checks in retries
(#221365)](#221365)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-23T14:50:23Z","message":"[Dataset
Quality] Wrap discover test checks in retries (#221365)\n\n##
Summary\n\nThis PR wraps test checks in retries to avoid checking before
loading is\ncompleted.\n\ncloses
https://github.com/elastic/kibana/issues/221348","sha":"a2bd0a73c6d44c42b3b62c457d8a6956049c6571","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","v9.1.0","v8.19.0"],"title":"[Dataset
Quality] Wrap discover test checks in
retries","number":221365,"url":"https://github.com/elastic/kibana/pull/221365","mergeCommit":{"message":"[Dataset
Quality] Wrap discover test checks in retries (#221365)\n\n##
Summary\n\nThis PR wraps test checks in retries to avoid checking before
loading is\ncompleted.\n\ncloses
https://github.com/elastic/kibana/issues/221348","sha":"a2bd0a73c6d44c42b3b62c457d8a6956049c6571"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221365","number":221365,"mergeCommit":{"message":"[Dataset
Quality] Wrap discover test checks in retries (#221365)\n\n##
Summary\n\nThis PR wraps test checks in retries to avoid checking before
loading is\ncompleted.\n\ncloses
https://github.com/elastic/kibana/issues/221348","sha":"a2bd0a73c6d44c42b3b62c457d8a6956049c6571"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.19.0 v9.1.0
Projects
None yet
4 participants