Search for CVE id in all search params instead of only name #221099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
added
release_note:enhancement
Team:Cloud Security
alexreal1314
approved these changes
May 21, 2025
Contributor
|
@maxcold LGTM |
Contributor
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💔 All backports failedManual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
maxcold
added a commit
that referenced
this pull request
May 27, 2025
…221099) (#221602) # Backport This will backport the following commits from `main` to `8.19`: - [Search for CVE id in all search params instead of only name (#221099)](#221099) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Maxim Kholod","email":"maxim.kholod@elastic.co"},"sourceCommit":{"committedDate":"2025-05-26T12:51:50Z","message":"Search for CVE id in all search params instead of only name (#221099)\n\n## Summary\n\nWhile reviewing Tenable mapping for CDR\nhttps://github.com/elastic/integrations/pull/13636 noticed that CVE link\nis not rendered for the following case\n\n```\nvulnerability.reference: [\n 'http://www.nessus.org/u?5b3cb0db',\n 'https://www.cve.org/CVERecord?id=CVE-2022-2068',\n 'https://www.openssl.org/news/secadv/20220621.txt',\n ];\nvulnerability.id: ['CVE-2022-2068']\n```\n\ndue to the find utility looking only into `name` search param. Fixing\nthat by iterating over all params\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"684c87750c0c4039724434d2dfe35d3b7a567a6f","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Cloud Security","backport:version","v9.1.0","v8.19.0"],"title":"Search for CVE id in all search params instead of only name","number":221099,"url":"https://github.com/elastic/kibana/pull/221099","mergeCommit":{"message":"Search for CVE id in all search params instead of only name (#221099)\n\n## Summary\n\nWhile reviewing Tenable mapping for CDR\nhttps://github.com/elastic/integrations/pull/13636 noticed that CVE link\nis not rendered for the following case\n\n```\nvulnerability.reference: [\n 'http://www.nessus.org/u?5b3cb0db',\n 'https://www.cve.org/CVERecord?id=CVE-2022-2068',\n 'https://www.openssl.org/news/secadv/20220621.txt',\n ];\nvulnerability.id: ['CVE-2022-2068']\n```\n\ndue to the find utility looking only into `name` search param. Fixing\nthat by iterating over all params\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"684c87750c0c4039724434d2dfe35d3b7a567a6f"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221099","number":221099,"mergeCommit":{"message":"Search for CVE id in all search params instead of only name (#221099)\n\n## Summary\n\nWhile reviewing Tenable mapping for CDR\nhttps://github.com/elastic/integrations/pull/13636 noticed that CVE link\nis not rendered for the following case\n\n```\nvulnerability.reference: [\n 'http://www.nessus.org/u?5b3cb0db',\n 'https://www.cve.org/CVERecord?id=CVE-2022-2068',\n 'https://www.openssl.org/news/secadv/20220621.txt',\n ];\nvulnerability.id: ['CVE-2022-2068']\n```\n\ndue to the find utility looking only into `name` search param. Fixing\nthat by iterating over all params\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"684c87750c0c4039724434d2dfe35d3b7a567a6f"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…221099) ## Summary While reviewing Tenable mapping for CDR elastic/integrations#13636 noticed that CVE link is not rendered for the following case ``` vulnerability.reference: [ 'http://www.nessus.org/u?5b3cb0db', 'https://www.cve.org/CVERecord?id=CVE-2022-2068', 'https://www.openssl.org/news/secadv/20220621.txt', ]; vulnerability.id: ['CVE-2022-2068'] ``` due to the find utility looking only into `name` search param. Fixing that by iterating over all params ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While reviewing Tenable mapping for CDR elastic/integrations#13636 noticed that CVE link is not rendered for the following case
due to the find utility looking only into
namesearch param. Fixing that by iterating over all paramsChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.