chore(streams): Significant events advanced settings #221316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csr
reviewed
Jun 18, 2025
| // expect(rules.body.data[0].params.query).to.eql( | ||
| // `FROM ${STREAM_NAME},${STREAM_NAME}.* METADATA _id, _source | WHERE KQL("""message:'OutOfMemoryError'""")` | ||
| // ); | ||
| const rules = await alertingApi.searchRules( |
Contributor
There was a problem hiding this comment.
Now that the feature flag is removed, should we remove this line too from feature_flags.ts?
miltonhultgren
approved these changes
Jun 20, 2025
Contributor
miltonhultgren
left a comment
miltonhultgren
left a comment
There was a problem hiding this comment.
Streams changes LGTM
adcoelho
approved these changes
Jun 24, 2025
kertal
approved these changes
Jun 24, 2025
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
cc @kdelemme |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This was referenced Jun 24, 2025
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Resolves elastic/streams-program#317 This PR introduces a new Advanced Settings for enabling streams significant events. It is disabled by default. This PR also registers the rule regardless of the settings. Using an Advanced Settings makes it easier for internal customers to toggle the feature on serverless. <img width="1495" alt="Screenshot 2025-06-17 at 11 15 11 AM" src="https://github.com/user-attachments/assets/27023c52-20a9-476f-9dfd-d3b8b3f03e94" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> (cherry picked from commit 8b65a14) # Conflicts: # x-pack/platform/plugins/private/discover_enhanced/ui_tests/tests/discover_cdp_perf.spec.ts # x-pack/test/tsconfig.json
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
Jun 25, 2025
## Summary Resolves elastic/streams-program#317 This PR introduces a new Advanced Settings for enabling streams significant events. It is disabled by default. This PR also registers the rule regardless of the settings. Using an Advanced Settings makes it easier for internal customers to toggle the feature on serverless. <img width="1495" alt="Screenshot 2025-06-17 at 11 15 11 AM" src="https://github.com/user-attachments/assets/27023c52-20a9-476f-9dfd-d3b8b3f03e94" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
dgieselaar
added a commit
that referenced
this pull request
Jun 25, 2025
…#225207) # Backport This will backport the following commits from `main` to `8.19`: - [chore(streams): Significant events advanced settings (#221316)](#221316) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-06-24T14:07:48Z","message":"chore(streams): Significant events advanced settings (#221316)\n\n## Summary\n\nResolves\nhttps://github.com/elastic/streams-program/issues/206?issue=elastic%7Cstreams-program%7C317\n\nThis PR introduces a new Advanced Settings for enabling streams\nsignificant events. It is disabled by default.\n\nThis PR also registers the rule regardless of the settings. \n\nUsing an Advanced Settings makes it easier for internal customers to\ntoggle the feature on serverless.\n\n<img width=\"1495\" alt=\"Screenshot 2025-06-17 at 11 15 11 AM\"\nsrc=\"https://github.com/user-attachments/assets/27023c52-20a9-476f-9dfd-d3b8b3f03e94\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"8b65a14fcc566ee92876374910cb3b691f01cdee","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","author:obs-ux-management"],"title":"chore(streams): Significant events advanced settings","number":221316,"url":"https://github.com/elastic/kibana/pull/221316","mergeCommit":{"message":"chore(streams): Significant events advanced settings (#221316)\n\n## Summary\n\nResolves\nhttps://github.com/elastic/streams-program/issues/206?issue=elastic%7Cstreams-program%7C317\n\nThis PR introduces a new Advanced Settings for enabling streams\nsignificant events. It is disabled by default.\n\nThis PR also registers the rule regardless of the settings. \n\nUsing an Advanced Settings makes it easier for internal customers to\ntoggle the feature on serverless.\n\n<img width=\"1495\" alt=\"Screenshot 2025-06-17 at 11 15 11 AM\"\nsrc=\"https://github.com/user-attachments/assets/27023c52-20a9-476f-9dfd-d3b8b3f03e94\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"8b65a14fcc566ee92876374910cb3b691f01cdee"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221316","number":221316,"mergeCommit":{"message":"chore(streams): Significant events advanced settings (#221316)\n\n## Summary\n\nResolves\nhttps://github.com/elastic/streams-program/issues/206?issue=elastic%7Cstreams-program%7C317\n\nThis PR introduces a new Advanced Settings for enabling streams\nsignificant events. It is disabled by default.\n\nThis PR also registers the rule regardless of the settings. \n\nUsing an Advanced Settings makes it easier for internal customers to\ntoggle the feature on serverless.\n\n<img width=\"1495\" alt=\"Screenshot 2025-06-17 at 11 15 11 AM\"\nsrc=\"https://github.com/user-attachments/assets/27023c52-20a9-476f-9dfd-d3b8b3f03e94\"\n/>\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>","sha":"8b65a14fcc566ee92876374910cb3b691f01cdee"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves https://github.com/elastic/streams-program/issues/206?issue=elastic%7Cstreams-program%7C317
This PR introduces a new Advanced Settings for enabling streams significant events. It is disabled by default.
This PR also registers the rule regardless of the settings.
Using an Advanced Settings makes it easier for internal customers to toggle the feature on serverless.