Skip to content

[ES|QL] Walker improvements #224582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vadimkibana merged 12 commits into from
Jun 24, 2025
Merged

[ES|QL] Walker improvements #224582

vadimkibana merged 12 commits into from
Jun 24, 2025

Conversation

@vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Jun 19, 2025 •
edited by kibanamachine
Loading

Summary

  • Implements traversal of source node children (string literals), like a and b in FROM a:b. Before a and b would not be traversed.
  • Implements traversal of order nodes, like field DESC in FROM a | SORT field DESC. Before the field DESC would be skipped.
  • Adds tests, which verify that all nodes in the query are traversed by the Walker, see walker_all_nodes.test.ts.

Checklist

@vadimkibana
Copy link
Contributor Author

vadimkibana commented Jun 19, 2025

/ci

@vadimkibana
Copy link
Contributor Author

vadimkibana commented Jun 20, 2025

/ci

@vadimkibana
Copy link
Contributor Author

vadimkibana commented Jun 23, 2025

/ci

@vadimkibana vadimkibana marked this pull request as ready for review June 23, 2025 12:42
@vadimkibana vadimkibana requested a review from a team as a code owner June 23, 2025 12:42
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 23, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 23, 2025

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana enabled auto-merge (squash) June 23, 2025 12:43
stratoula
stratoula approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@vadimkibana vadimkibana merged commit f433e7a into elastic:main Jun 24, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 24, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15857351002

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 24, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-ast 328 338 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +35.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.7MB 3.7MB +527.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 409 419 +10

History

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 24, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [Security solution] Remove feature flag, always automatically install prompts (#224489)
- Update copy for bulk fill gaps UI (#225070)
- [Obs AI Assistant] Add query rewriting (#224498)
- [ReponseOps][Reporting] Allow users to schedule reports and view schedules list (#224849)
- Use bulk helper for bulk importing knowledge base entries (#223526)
- chore(streams): Significant events advanced settings (#221316)
- upgrade pw to 1.53.1 !! (#225043)
- [Security Solution] Implement prebuilt rules import test plan (#223421)
- [ObsUX] Remove entities v2 code and Inventory (#224696)
- Render accordion in integration readme (#223916)

Manual backport

To create the backport manually run:

node scripts/backport --pr 224582

Questions ?

Please refer to the Backport tool documentation

@vadimkibana vadimkibana mentioned this pull request Jun 25, 2025
Merged
@vadimkibana
Copy link
Contributor Author

vadimkibana commented Jun 25, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

vadimkibana added a commit to vadimkibana/kibana that referenced this pull request Jun 25, 2025
@vadimkibana
[ES|QL] Walker improvements (elastic#224582)
8ccc4b6 
## Summary

- Implements traversal of `source` node children (string literals), like
`a` and `b` in `FROM a:b`. Before `a` and `b` would not be traversed.
- Implements traversal of `order` nodes, like `field DESC` in `FROM a |
SORT field DESC`. Before the `field DESC` would be skipped.
- Adds tests, which verify that all nodes in the query are traversed by
the `Walker`, see `walker_all_nodes.test.ts`.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit f433e7a)

# Conflicts:
#	src/platform/packages/shared/kbn-monaco/src/esql/lib/hover/hover.test.ts
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
@vadimkibana @akowalska622
[ES|QL] Walker improvements (elastic#224582)
14a7e92 
## Summary

- Implements traversal of `source` node children (string literals), like
`a` and `b` in `FROM a:b`. Before `a` and `b` would not be traversed.
- Implements traversal of `order` nodes, like `field DESC` in `FROM a |
SORT field DESC`. Before the `field DESC` would be skipped.
- Adds tests, which verify that all nodes in the query are traversed by
the `Walker`, see `walker_all_nodes.test.ts`.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 26, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 26, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @vadimkibana

vadimkibana added a commit that referenced this pull request Jun 27, 2025
@vadimkibana
[8.19] [ES|QL] Walker improvements (#224582) (#225230)
5329ff7 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] `Walker` improvements
(#224582)](#224582)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Vadim
Kibana","email":"82822460+vadimkibana@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-24T17:28:34Z","message":"[ES|QL]
`Walker` improvements (#224582)\n\n## Summary\n\n- Implements traversal
of `source` node children (string literals), like\n`a` and `b` in `FROM
a:b`. Before `a` and `b` would not be traversed.\n- Implements traversal
of `order` nodes, like `field DESC` in `FROM a |\nSORT field DESC`.
Before the `field DESC` would be skipped.\n- Adds tests, which verify
that all nodes in the query are traversed by\nthe `Walker`, see
`walker_all_nodes.test.ts`.\n\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f433e7aa97ca30f57defea9156fcf9163b1e1468","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
`Walker` improvements
","number":224582,"url":"https://github.com/elastic/kibana/pull/224582","mergeCommit":{"message":"[ES|QL]
`Walker` improvements (#224582)\n\n## Summary\n\n- Implements traversal
of `source` node children (string literals), like\n`a` and `b` in `FROM
a:b`. Before `a` and `b` would not be traversed.\n- Implements traversal
of `order` nodes, like `field DESC` in `FROM a |\nSORT field DESC`.
Before the `field DESC` would be skipped.\n- Adds tests, which verify
that all nodes in the query are traversed by\nthe `Walker`, see
`walker_all_nodes.test.ts`.\n\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f433e7aa97ca30f57defea9156fcf9163b1e1468"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224582","number":224582,"mergeCommit":{"message":"[ES|QL]
`Walker` improvements (#224582)\n\n## Summary\n\n- Implements traversal
of `source` node children (string literals), like\n`a` and `b` in `FROM
a:b`. Before `a` and `b` would not be traversed.\n- Implements traversal
of `order` nodes, like `field DESC` in `FROM a |\nSORT field DESC`.
Before the `field DESC` would be skipped.\n- Adds tests, which verify
that all nodes in the query are traversed by\nthe `Walker`, see
`walker_all_nodes.test.ts`.\n\n\n### Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"f433e7aa97ca30f57defea9156fcf9163b1e1468"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vadimkibana @elasticmachine @kibanamachine @stratoula @streamich