Skip to content

[integration/peerlab] Bugfix: Warn instead of Fail when margins are too large #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobiaspk merged 1 commit into from
May 8, 2026
Merged

[integration/peerlab] Bugfix: Warn instead of Fail when margins are too large #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/segger/data/tiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,15 @@ def _query_tiles(
mitre_limit=margin / 2,
)
missing = buffered.is_empty.sum()
# handling tiles too small for buffer
if missing != 0:
raise ValueError(
import warnings
warnings.warn(
f"Margin ({margin}) is too large, causing {missing} "
f"tile(s) to disappear. Consider using a smaller margin."
f"tile(s) to disappear. These tiles will be removed from the query."
)
# Filter out the empty tiles
buffered = buffered[~buffered.is_empty]
tiles = buffered

# Spatial query
Expand Down