[integration/peerlab] Bugfix: Warn instead of Fail when margins are too large#34
Open
Tobiaspk wants to merge 1 commit intointegration/peerlabfrom
Open
[integration/peerlab] Bugfix: Warn instead of Fail when margins are too large#34Tobiaspk wants to merge 1 commit intointegration/peerlabfrom
Tobiaspk wants to merge 1 commit intointegration/peerlabfrom
Conversation
Collaborator
Author
|
Still in testing for a minute. |
Tobiaspk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
If margins are too large, segger currently fails instead of removing empty tiles. Future fix should include adaptive tiling parameters, this should do for now though. Thanks @srose89