Skip to content

[Android] VoiceOver on Toolbar Item #29596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Android] VoiceOver on Toolbar Item #29596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions src/Controls/src/Core/Platform/Android/Extensions/ToolbarExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
using Android.Views;
using AndroidX.AppCompat.Graphics.Drawable;
using AndroidX.AppCompat.Widget;
using AndroidX.Core.View;
using AndroidX.Core.View.Accessibility;
using Microsoft.Maui.Graphics;
using Microsoft.Maui.Primitives;
using AGraphics = Android.Graphics;
Expand Down Expand Up @@ -348,6 +350,56 @@ static void UpdateMenuItem(AToolbar toolbar,
textView.SetTextColor(tintColor.MultiplyAlpha(0.302f).ToPlatform());
}
}

SetSemanticProperties(item, toolbar.FindViewById(menuitem.ItemId));
}

static void SetSemanticProperties(ToolbarItem menuItem, AView? view)
{
if (view == null)
return;

var semantics = SemanticProperties.UpdateSemantics(menuItem, null);
var desc = semantics?.Description;
var hint = semantics?.Hint;

// Only apply delegate if we have meaningful accessibility information
if (!string.IsNullOrWhiteSpace(desc) || !string.IsNullOrWhiteSpace(hint))
{
view.ImportantForAccessibility = ImportantForAccessibility.Yes;
ViewCompat.SetAccessibilityDelegate(view, new AccessibilityDelegateCompatImpl(desc, hint));
}
else
{
// Remove any previously set delegate if no accessibility info is present
ViewCompat.SetAccessibilityDelegate(view, null);
}
}

class AccessibilityDelegateCompatImpl : AccessibilityDelegateCompat
{
private readonly string? _desc;
private readonly string? _hint;

public AccessibilityDelegateCompatImpl(string? desc, string? hint)
{
_desc = desc;
_hint = hint;
}

public override void OnInitializeAccessibilityNodeInfo(AView? host, AccessibilityNodeInfoCompat? info)
{
base.OnInitializeAccessibilityNodeInfo(host, info);

if (host == null || info == null)
return;

if (!string.IsNullOrWhiteSpace(_desc))
info.ContentDescription = _desc;

if (!string.IsNullOrWhiteSpace(_hint))
info.HintText = _hint;
}
}

internal static void UpdateMenuItemIcon(this IMauiContext mauiContext, IMenuItem menuItem, ToolbarItem toolBarItem, Color? tintColor)
Expand Down
Loading