[Android] VoiceOver on Toolbar Item #29596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the accessibility support for Android Toolbar items by configuring VoiceOver semantics.
- Introduces a new helper method, SetSemanticProperties, to update accessibility information on Toolbar items.
- Implements the AccessibilityDelegateCompatImpl to correctly set ContentDescription and HintText based on semantic properties.
- Adds necessary AndroidX Core API references needed for the enhancements.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Platform/Android/Extensions/ToolbarExtensions.cs:354
- Ensure that automated tests are added in TestCases.HostApp and TestCases.Shared.Tests to verify that the new accessibility delegate correctly applies the semantic properties (ContentDescription and HintText) on Toolbar items.
SetSemanticProperties(item, toolbar.FindViewById(menuitem.ItemId));
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android
area-controls-toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #29573
Fixes #23623