[pac] GQL backend #33253

OwenKephart · 2026-01-14T00:30:01Z

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

OwenKephart · 2026-01-14T00:30:10Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

[pac] frontend #33255 : 2 dependent PRs (#33288 , #33352 )
[pac] UI refactor #33254
[pac] GQL backend #33253 👈 (View in Graphite)
[pac] reverse order of check event / asset event creation #33348
[pac] move to PartitionKeyFilter #33336
[pac] add AssetCheckState #33243
[pac] Add get_asset_check_partition_info storage method #33242
[pac] Update user-facing APIs and snapshots #33236
[pac] Update status resolution logic #33235
[pac] Add partitions_subset to AssetCheckEvaluationPlanned, partition to AssetCheckEvaluation/AssetCheckEvaluationRecord #33231
[record] asset_check_evaluation.py #33204
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-01-14T00:32:33Z

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-g3kk7ilgw-elementl.vercel.app
https://01-13--pac-gql-backend.core-storybook.dagster-docs.io

Built with commit aafa579.
This pull request is being automatically deployed with vercel-action

gibsondan

this all seems reasonable but the test coverage seems a little light - are you confident we have all this gnarly 2d dimension stuff covered / all the various partition types and statuses / stressing the run-length encoding / etc.?

gibsondan · 2026-01-22T23:09:00Z

python_modules/dagster-graphql/dagster_graphql/schema/asset_graph.py

        asset_check_support = graphene_info.context.instance.get_asset_check_support()
        if asset_check_support == AssetCheckInstanceSupport.NEEDS_MIGRATION:
            return GrapheneAssetCheckNeedsMigrationError(


i assume you meant to delete this block

gibsondan · 2026-01-22T23:11:00Z

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_asset_checks.py

+       - MultiPartitionsDefinition in partitions_def → build_multi_partition_statuses_for_checks()
+       - Otherwise → build_default_partition_statuses_for_checks()
+
+    Note: Missing status is calculated on the frontend as the complement of all known statuses.


heh I had to look this one up for review

gibsondan · 2026-01-22T23:15:05Z

python_modules/dagster-graphql/dagster_graphql/implementation/fetch_asset_checks.py

+            secondary_serializable_subsets[status] = SerializableEntitySubset.from_coercible_value(
+                key,
+                list(secondary_subset.get_partition_keys()),
+                partitions_def.secondary_dimension.partitions_def,
+            )


this method can raise an exception no? if there's something invalid about the subset now?

gibsondan · 2026-01-22T23:21:53Z

python_modules/dagster-graphql/dagster_graphql/schema/asset_checks.py

+        partition_status = await AssetCheckState.gen(
+            graphene_info.context, (check_key, current_partition_def)
+        )


This will be able to batch multiple keys right? not sure if we ever do that for this particular resolver

This was referenced Jan 14, 2026

[pac] UI refactor #33254

Open

[pac] frontend #33255

Open

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from 04a0928 to 2d22edf Compare January 14, 2026 19:44

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from ee869fb to 24088d1 Compare January 14, 2026 19:44

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from 2d22edf to a46ebcd Compare January 14, 2026 21:10

OwenKephart force-pushed the 01-13-_pac_gql_backend branch 2 times, most recently from 413e5b2 to 9de34a6 Compare January 14, 2026 21:45

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch 2 times, most recently from 41c2116 to 8924e96 Compare January 14, 2026 23:04

OwenKephart force-pushed the 01-13-_pac_gql_backend branch 2 times, most recently from 6c29e1e to b61afb6 Compare January 16, 2026 00:42

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from 8924e96 to 31a51b3 Compare January 16, 2026 00:42

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from b61afb6 to 72de2cb Compare January 16, 2026 00:43

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from 31a51b3 to 3fd86b4 Compare January 16, 2026 00:43

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from 72de2cb to d17ed50 Compare January 16, 2026 01:03

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch 2 times, most recently from 18cc9f0 to 2a99818 Compare January 16, 2026 01:15

OwenKephart force-pushed the 01-13-_pac_gql_backend branch 2 times, most recently from 11982eb to cf41ddf Compare January 16, 2026 20:41

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from 2a99818 to e9e1b75 Compare January 16, 2026 20:41

OwenKephart mentioned this pull request Jan 16, 2026

[pac] refactor / rename AssetCheckPartitionState #33288

Closed

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from e9e1b75 to ca6ec29 Compare January 16, 2026 21:44

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from cd6e372 to 4e18318 Compare January 20, 2026 20:48

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from b2d651b to b6a9634 Compare January 20, 2026 23:44

OwenKephart force-pushed the 01-13-_pac_gql_backend branch 2 times, most recently from 01b1c94 to d8da365 Compare January 21, 2026 00:01

OwenKephart force-pushed the 01-09-_pac_add_assetcheckstatuscachevalue branch from b6a9634 to 3c493b4 Compare January 21, 2026 00:01

OwenKephart changed the base branch from 01-09-_pac_add_assetcheckstatuscachevalue to graphite-base/33253 January 22, 2026 00:11

OwenKephart force-pushed the graphite-base/33253 branch from 3c493b4 to db921e5 Compare January 22, 2026 00:11

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from d8da365 to 1815cf2 Compare January 22, 2026 00:11

OwenKephart changed the base branch from graphite-base/33253 to 01-21-_pac_move_to_partitionkeyfilter January 22, 2026 00:12

OwenKephart mentioned this pull request Jan 22, 2026

[pac] move to PartitionKeyFilter #33336

Open

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from 1815cf2 to 0b675d3 Compare January 22, 2026 03:20

OwenKephart force-pushed the 01-21-_pac_move_to_partitionkeyfilter branch from db921e5 to 01c4dff Compare January 22, 2026 03:20

OwenKephart requested review from gibsondan and prha January 22, 2026 18:36

OwenKephart changed the base branch from 01-21-_pac_move_to_partitionkeyfilter to graphite-base/33253 January 22, 2026 21:25

OwenKephart force-pushed the graphite-base/33253 branch from 01c4dff to 6dd4ddf Compare January 22, 2026 21:25

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from 0b675d3 to 043aa4e Compare January 22, 2026 21:25

OwenKephart changed the base branch from graphite-base/33253 to 01-22-_pac_reverse_order_of_check_event___asset_event_creation January 22, 2026 21:25

OwenKephart mentioned this pull request Jan 22, 2026

[pac] reverse order of check event / asset event creation #33348

Open

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from 043aa4e to e34146a Compare January 22, 2026 21:55

OwenKephart force-pushed the 01-22-_pac_reverse_order_of_check_event___asset_event_creation branch 2 times, most recently from 1601a4b to 8deb6a2 Compare January 22, 2026 21:57

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from e34146a to 390d0b2 Compare January 22, 2026 21:57

OwenKephart force-pushed the 01-22-_pac_reverse_order_of_check_event___asset_event_creation branch from 8deb6a2 to eee594c Compare January 22, 2026 23:16

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from 390d0b2 to cc394fd Compare January 22, 2026 23:16

gibsondan approved these changes Jan 22, 2026

View reviewed changes

[pac] GQL backend

aafa579

OwenKephart force-pushed the 01-22-_pac_reverse_order_of_check_event___asset_event_creation branch from eee594c to 92673d1 Compare January 23, 2026 00:46

OwenKephart force-pushed the 01-13-_pac_gql_backend branch from cc394fd to aafa579 Compare January 23, 2026 00:46

OwenKephart mentioned this pull request Jan 23, 2026

[pac][ui] better status rollup handling #33352

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pac] GQL backend #33253

[pac] GQL backend #33253

OwenKephart commented Jan 14, 2026

Uh oh!

OwenKephart commented Jan 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

gibsondan left a comment

Uh oh!

gibsondan Jan 22, 2026

Uh oh!

gibsondan Jan 22, 2026

Uh oh!

gibsondan Jan 22, 2026

Uh oh!

gibsondan Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[pac] GQL backend #33253

Are you sure you want to change the base?

[pac] GQL backend #33253

Conversation

OwenKephart commented Jan 14, 2026

Summary & Motivation

How I Tested These Changes

Changelog

Uh oh!

OwenKephart commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibsondan left a comment

Choose a reason for hiding this comment

Uh oh!

gibsondan Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gibsondan Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gibsondan Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gibsondan Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OwenKephart commented Jan 14, 2026 •

edited

Loading

github-actions bot commented Jan 14, 2026 •

edited

Loading