Auto-focus parameter filter on typing#779
Merged
Merged
Conversation
Focus the filter input in the simulation parameters window as soon as the user starts typing, without having to click the field first. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the simulation parameters window the filter field now grabs keyboard focus the moment the user starts typing — no need to click into the filter widget first.
Details
SimulationParametersMainWindow::shouldStartFilterTyping()returns true when the window (incl. child windows) is focused, no other item is active, and a printable character was entered this frame.ImGui::SetKeyboardFocusHere()is called right before the filterInputText, so the first typed character already lands in the filter.IsAnyItemActive()is true, so there is no focus-fighting.Test
build-windows-ninja.bat 16) succeeds,alien.exelinks.🤖 Generated with Claude Code