Fix filter typing needing two keypresses to start#783
Merged
Conversation
SetKeyboardFocusHere() only takes effect one frame later, so the character that triggered it was lost before the input widget became active. Append it to the filter directly instead.
Escape now clears the filter field instead of just reverting it, and starting to type replaces the previous filter instead of appending to it. Also drops the imgui_internal.h dependency by encoding the typed character as UTF-8 ourselves.
The manually-spliced first character got selected by ImGui's auto-select-on-programmatic-focus behavior, so the next keystroke replaced it instead of appending. Replay the queued characters into ImGui's input queue on the activation frame instead, letting ImGui's own selection/insertion logic handle them correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImGui::SetKeyboardFocusHere()resolves focus at the start of the next frame, so the character queued inio.InputQueueCharacterson the triggering frame is discarded before the input widget becomes active and can consume it._filterdirectly (UTF-8 encoded viaImTextCharToUtf8) and only useSetKeyboardFocusHere()to move the cursor/focus into the field for subsequent frames.Test plan
build-windows-ninja.bat Releasebuilds cleanly