Skip to content

fix: wait for TLS secrets cache sync before loading certificates #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
racciari wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix: wait for TLS secrets cache sync before loading certificates #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/controller/action_tls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package controller

import (
"fmt"
"os"
"path/filepath"

"github.com/caddyserver/ingress/internal/k8s"
apiv1 "k8s.io/api/core/v1"
"k8s.io/client-go/tools/cache"
)

var certFolder = ""
Expand Down Expand Up @@ -118,6 +120,13 @@ func (c *CaddyController) watchTLSSecrets() error {
// Run it
go c.informers.TLSSecret.Run(c.stopChan)

// Wait for the TLSSecret informer to sync before loading certificates.
// This prevents a race condition where Caddy starts listening before
// certificates are written to disk.
if !cache.WaitForCacheSync(c.stopChan, c.informers.TLSSecret.HasSynced) {
return fmt.Errorf("timed out waiting for TLS secrets cache to sync")
}

// Sync secrets
secrets, err := k8s.ListTLSSecrets(params, c.resourceStore.Ingresses)
if err != nil {
Expand Down