fix: wait for TLS secrets cache sync before loading certificates#345
Open
racciari wants to merge 1 commit intocaddyserver:mainfrom
Open
fix: wait for TLS secrets cache sync before loading certificates#345racciari wants to merge 1 commit intocaddyserver:mainfrom
racciari wants to merge 1 commit intocaddyserver:mainfrom
Conversation
Add WaitForCacheSync for the TLSSecret informer to prevent a race condition where Caddy starts listening before TLS certificates are written to disk. Without this fix, when the controller starts: 1. TLSSecret informer is started asynchronously 2. Caddy config is loaded (which references the cert folder) 3. Caddy starts listening on :443 4. TLS certificates are written ~100ms later This causes SSL_PROTOCOL_ERROR for the first TLS handshakes because Caddy has no certificates loaded (cert_cache_fill: 0). The fix ensures the TLSSecret informer has synced (and certificates are written) before watchTLSSecrets() returns, guaranteeing certs are present when Caddy loads its config.
Author
|
Linked to #277 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add WaitForCacheSync for the TLSSecret informer to prevent a race condition where Caddy starts listening before TLS certificates are written to disk.
Without this fix, when the controller starts:
This causes SSL_PROTOCOL_ERROR for the first TLS handshakes because Caddy has no certificates loaded (cert_cache_fill: 0).
The fix ensures the TLSSecret informer has synced (and certificates are written) before watchTLSSecrets() returns, guaranteeing certs are present when Caddy loads its config.