Skip to content

BRE-552 - Flip Actionlint rule to error #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/actionlint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Configuration related to self-hosted runner.
self-hosted-runner:
# Labels of self-hosted runner in array of strings.
labels:
- terraform-provider-bitwarden-sm-linux

# Path-specific configurations.
paths:
# Glob pattern relative to the repository root for matching files. The path separator is always '/'.
# This example configures any YAML file under the '.github/workflows/' directory.
.github/workflows/**/*.{yml,yaml}:
# List of regular expressions to filter errors by the error messages.
ignore:
# Ignore the specific error from shellcheck
- 'shellcheck reported issue in this script: .+'
4 changes: 2 additions & 2 deletions .github/workflows/bwwl_operations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: python -m pip install --upgrade bitwarden_workflow_linter

- name: Create Branch
if: ${{ github.events_name == 'schedule' || inputs.operation == 'update' }}
if: ${{ github.event_name == 'schedule' || inputs.operation == 'update' }}
run: |
NAME="update-actions-$(date +'%Y%m%d-%H%M%S')"
git switch -c $NAME
Expand All @@ -77,7 +77,7 @@ jobs:
echo "BRANCH_NAME=$NAME" >> $GITHUB_ENV

- name: Run bwwl update
if: ${{ github.events_name == 'schedule' || inputs.operation == 'update' }}
if: ${{ github.event_name == 'schedule' || inputs.operation == 'update' }}
run: bwwl actions update -o src/bitwarden_workflow_linter/default_actions.json

- name: Run bwwl add
Expand Down
4 changes: 0 additions & 4 deletions actionlint_version.json

This file was deleted.

2 changes: 1 addition & 1 deletion settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ enabled_rules:
- id: bitwarden_workflow_linter.rules.underscore_outputs.RuleUnderscoreOutputs
level: warning
- id: bitwarden_workflow_linter.rules.run_actionlint.RunActionlint
level: warning
level: error
- id: bitwarden_workflow_linter.rules.check_pr_target.RuleCheckPrTarget
level: error
- id: bitwarden_workflow_linter.rules.permissions_exist.RulePermissionsExist
Expand Down
2 changes: 1 addition & 1 deletion src/bitwarden_workflow_linter/default_settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ enabled_rules:
- id: bitwarden_workflow_linter.rules.underscore_outputs.RuleUnderscoreOutputs
level: warning
- id: bitwarden_workflow_linter.rules.run_actionlint.RunActionlint
level: warning
level: error
- id: bitwarden_workflow_linter.rules.check_pr_target.RuleCheckPrTarget
level: error
- id: bitwarden_workflow_linter.rules.permissions_exist.RulePermissionsExist
Expand Down
Loading