Skip to content

BRE-552 - Flip Actionlint rule to error #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented May 20, 2025

🎟️ Tracking

📔 Objective

This PR updates the default and current settings of the Actionlint rule to error instead of warning, introduces an actionlint.yml configuration file for customizing actionlint, and fixes for the bwwl_operations.yml workflow.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this May 20, 2025
Copy link

github-actions bot commented May 20, 2025

Logo
Checkmarx One – Scan Summary & Details91d888cf-d586-4428-8439-642bfeec4e62

Great job, no security vulnerabilities found in this Pull Request

@vgrassia vgrassia force-pushed the bre-552_flip-actionlint-rule-to-error branch from bfb14a4 to c93513a Compare May 20, 2025 16:38
@vgrassia vgrassia marked this pull request as ready for review May 21, 2025 13:57
@vgrassia vgrassia requested a review from a team as a code owner May 21, 2025 13:57
@vgrassia vgrassia requested a review from Eeebru May 21, 2025 13:57
@Eeebru Eeebru added the hold label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants