-
Notifications
You must be signed in to change notification settings - Fork 12
[PM-23189] Add ClientManagedTokens trait #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 71.70% 71.62% -0.08%
==========================================
Files 238 239 +1
Lines 19317 19346 +29
==========================================
+ Hits 13851 13857 +6
- Misses 5466 5489 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes `get_client_managed` to return a `Result<_, RepositoryNotFound>` based on discussions in #337 (comment)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-23189
📔 Objective
Adds support for client managed access tokens alongside SDK managed access tokens.
It does so by splitting
Tokens
intoSdkManaged
andClientManaged
.ClientManaged
relies on the consumer implementing a trait withget_access_token
function.In WASM this is exposed as a
TokenProvider
interface which can be implemented in TS clients using:⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes