Skip to content

Change get_client_managed to return result #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jun 30, 2025

🎟️ Tracking

📔 Objective

Changes get_client_managed to return a Result<_, RepositoryNotFound> based on discussions in #337 (comment)

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner June 30, 2025 14:45
@Hinton Hinton requested a review from dani-garcia June 30, 2025 14:45
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details47d93d04-6cca-4985-83dd-10eebd4419ee

Great job, no security vulnerabilities found in this Pull Request

Copy link

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (0cc1aed) to head (89d53c3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-core/src/platform/state_client.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   71.70%   71.70%   -0.01%     
==========================================
  Files         238      238              
  Lines       19312    19317       +5     
==========================================
+ Hits        13848    13851       +3     
- Misses       5464     5466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton merged commit 4e60721 into main Jul 1, 2025
50 checks passed
@Hinton Hinton deleted the arch/registry-error branch July 1, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants