-
Notifications
You must be signed in to change notification settings - Fork 10
Remove duplicated Cipher and Folder client #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 69.83% 70.07% +0.24%
==========================================
Files 213 212 -1
Lines 16809 16905 +96
==========================================
+ Hits 11738 11846 +108
+ Misses 5071 5059 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
📔 Objective
Changes
uuid
to be represented as unknown which causes mostas
casts to fail since TS safeguards against casting "string" to unknown. Adds a new type calledOrganizationId
which is manually set to be equal toTagged<Uuid, "OrganizationId">
on the TS side. This prevents mixing up the type with other Uuid's.In order to create an OrganizationId in the application you now need to pass through unknown otherwise you get the following error message:
Conversion of type 'string' to type 'Tag<"OrganizationId", never>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
To provide some ergonomics we should add the following function in typescript:
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes