-
Notifications
You must be signed in to change notification settings - Fork 11
[PM-13374] Add UserId, CipherId, FolderId #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 71.76% 71.76% -0.01%
==========================================
Files 224 224
Lines 18384 18401 +17
==========================================
+ Hits 13193 13205 +12
- Misses 5191 5196 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…re-uuids # Conflicts: # crates/bitwarden-core/src/client/encryption_settings.rs # crates/bitwarden-core/src/client/internal.rs
…re-uuids # Conflicts: # crates/bitwarden-core/src/client/internal.rs # crates/bitwarden-core/src/mobile/crypto.rs # crates/bitwarden-vault/src/cipher/cipher.rs # crates/bitwarden-vault/src/collection.rs # crates/bitwarden-vault/src/folder.rs
…re-uuids # Conflicts: # crates/bitwarden-core/src/auth/auth_request.rs # crates/bitwarden-core/src/client/test_accounts.rs # crates/bitwarden-core/src/key_management/mod.rs # crates/bitwarden-core/tests/register.rs
…re-uuids # Conflicts: # crates/bitwarden-core/src/key_management/crypto.rs
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13374
📔 Objective
Continues the work on #225 by introducing
UserId
,CipherId
andFolderId
. It also propagates theOrganizationId
deeper into the core crate.uuid
macro touuid_newtype
, avoids collision with the macro fromuuid
crate.Hash
to the uuids.new_v4
primarily useful in tests to generate valid UUID v4 based IDs.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes