Skip to content

[PM-13374] Add UserId, CipherId, FolderId #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 26, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13374

📔 Objective

Continues the work on #225 by introducing UserId, CipherId and FolderId. It also propagates the OrganizationId deeper into the core crate.

  • Renamed uuid macro to uuid_newtype, avoids collision with the macro from uuid crate.
  • Added Hash to the uuids.
  • Added new_v4 primarily useful in tests to generate valid UUID v4 based IDs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton marked this pull request as ready for review May 26, 2025 09:26
@Hinton Hinton requested a review from a team as a code owner May 26, 2025 09:26
@Hinton Hinton requested a review from dani-garcia May 26, 2025 09:26
dani-garcia
dani-garcia previously approved these changes May 26, 2025
Copy link
Contributor

github-actions bot commented May 26, 2025

Logo
Checkmarx One – Scan Summary & Details7fecfd7f-55d8-467d-abf5-a5b20e1c7283

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 58.10811% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (c9bd7f9) to head (a512712).

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/cipher/cipher.rs 47.05% 9 Missing ⚠️
crates/bitwarden-fido/src/types.rs 0.00% 4 Missing ⚠️
crates/bitwarden-vault/src/sync.rs 0.00% 3 Missing ⚠️
...ates/bitwarden-core/src/auth/login/access_token.rs 0.00% 2 Missing ⚠️
crates/bitwarden-uniffi/src/vault/ciphers.rs 0.00% 2 Missing ⚠️
crates/bitwarden-vault/src/collection.rs 33.33% 2 Missing ⚠️
...warden_license/bitwarden-sm/src/projects/create.rs 0.00% 1 Missing ⚠️
...ense/bitwarden-sm/src/projects/project_response.rs 0.00% 1 Missing ⚠️
...warden_license/bitwarden-sm/src/projects/update.rs 0.00% 1 Missing ⚠️
...twarden_license/bitwarden-sm/src/secrets/create.rs 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   71.76%   71.76%   -0.01%     
==========================================
  Files         224      224              
  Lines       18384    18401      +17     
==========================================
+ Hits        13193    13205      +12     
- Misses       5191     5196       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dani-garcia
dani-garcia previously approved these changes May 26, 2025
@Hinton Hinton requested a review from gbubemismith May 27, 2025 08:03
@Hinton Hinton changed the title Add UserId, CipherId, FolderId [PM-13374] Add UserId, CipherId, FolderId May 29, 2025
gbubemismith
gbubemismith previously approved these changes Jun 2, 2025
…re-uuids

# Conflicts:
#	crates/bitwarden-core/src/client/encryption_settings.rs
#	crates/bitwarden-core/src/client/internal.rs
@Hinton Hinton dismissed stale reviews from gbubemismith and dani-garcia via 67ba9d1 June 3, 2025 11:59
@Hinton Hinton requested a review from dani-garcia June 3, 2025 12:21
dani-garcia
dani-garcia previously approved these changes Jun 3, 2025
…re-uuids

# Conflicts:
#	crates/bitwarden-core/src/client/internal.rs
#	crates/bitwarden-core/src/mobile/crypto.rs
#	crates/bitwarden-vault/src/cipher/cipher.rs
#	crates/bitwarden-vault/src/collection.rs
#	crates/bitwarden-vault/src/folder.rs
@Hinton Hinton requested a review from a team as a code owner June 9, 2025 13:20
@Hinton Hinton requested a review from shane-melton June 9, 2025 13:20
@Hinton Hinton requested a review from dani-garcia June 10, 2025 12:55
gbubemismith
gbubemismith previously approved these changes Jun 10, 2025
dani-garcia
dani-garcia previously approved these changes Jun 11, 2025
…re-uuids

# Conflicts:
#	crates/bitwarden-core/src/auth/auth_request.rs
#	crates/bitwarden-core/src/client/test_accounts.rs
#	crates/bitwarden-core/src/key_management/mod.rs
#	crates/bitwarden-core/tests/register.rs
@Hinton Hinton dismissed stale reviews from dani-garcia and gbubemismith via 053de35 June 12, 2025 11:09
…re-uuids

# Conflicts:
#	crates/bitwarden-core/src/key_management/crypto.rs
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants