Skip to content

[PM-37190] Use state bridge instead of platform state - #1155

Open
quexten wants to merge 3 commits into
mainfrom
km/ephemeral-state-cleanup
Open

[PM-37190] Use state bridge instead of platform state#1155
quexten wants to merge 3 commits into
mainfrom
km/ephemeral-state-cleanup

Conversation

@quexten

@quexten quexten commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37190
PR to resolve breaking changes on TS: bitwarden/clients#20976

📔 Objective

Migrates ephemeral KM state away from the repository access pattern, and only uses the state bridge, until platform provides a single-key-access-mechanism via settings.
This unblocks bitwarden/clients#20976 which migrates back from the temporary hack we had to introduce to fit into the shape of the platform API.

🚨 Breaking Changes

@quexten quexten changed the title Use state bridge instead of platform state [PM-37190] Use state bridge instead of platform state Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🔍 SDK Breaking Change Detection

SDK Version: km/ephemeral-state-cleanup (8dcaede)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client Status Details
typescript ❌ Breaking changes detected Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes must be ready for merge in bitwarden/clients. - View Details
android ❌ Breaking changes detected Compilation failed with new SDK version. A corresponding pull request addressing the breaking changes must be ready for merge in bitwarden/android. - View Details

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

@quexten
quexten marked this pull request as ready for review June 2, 2026 10:44
@quexten
quexten requested review from a team as code owners June 2, 2026 10:44
@quexten
quexten requested review from djsmith85 and mzieniukbw June 2, 2026 10:44
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.12%. Comparing base (3a2a20c) to head (179633a).
⚠️ Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
...arden-core/src/key_management/wasm_unlock_state.rs 52.38% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   83.90%   84.12%   +0.22%     
==========================================
  Files         438      446       +8     
  Lines       57051    58790    +1739     
==========================================
+ Hits        47869    49460    +1591     
- Misses       9182     9330     +148     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mzieniukbw mzieniukbw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android build is failing, I assume we won't merge it we get green light from mobile team ?

Comment thread crates/bitwarden-core/src/key_management/wasm_unlock_state.rs Outdated
Comment thread crates/bitwarden-core/src/key_management/wasm_unlock_state.rs Outdated
@quexten

quexten commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Please note this PR is blocked until mobile implements the state bridge and has a corresponding PR ready to update to this. It will not be merged until then.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@djsmith85
djsmith85 requested review from dani-garcia and removed request for djsmith85 June 8, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants