[PM-37190] Clean up ephemeral states that go via state bridge - #20976
[PM-37190] Clean up ephemeral states that go via state bridge#20976quexten wants to merge 3 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR cleans up the ephemeral state shapes for Code Review DetailsNo actionable findings. Notes considered and dismissed:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20976 +/- ##
==========================================
+ Coverage 48.07% 48.34% +0.26%
==========================================
Files 4032 4025 -7
Lines 124881 124101 -780
Branches 19112 18982 -130
==========================================
- Hits 60034 59991 -43
+ Misses 60352 59624 -728
+ Partials 4495 4486 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like the lint failure is unrelated to this PR |
|
| @@ -17,17 +15,13 @@ export async function initializeClientManagedState( | |||
| stateClient.register_client_managed_repositories({ | |||
| cipher: new RepositoryRecord(userId, stateProvider, new CipherRecordMapper(), true), | |||
| folder: null, | |||
| user_key_state: new RepositoryRecord(userId, stateProvider, new UserKeyRecordMapper()), | |||
| user_key_state: null, | |||
There was a problem hiding this comment.
This won't exist anymore and needs to be removed, instead of nulled.
| stateProvider, | ||
| new EphemeralPinEnvelopeMapper(), | ||
| ), | ||
| ephemeral_pin_envelope_state: null, |
There was a problem hiding this comment.
This won't exist anymore and needs to be removed, instead of nulled.
djsmith85
left a comment
There was a problem hiding this comment.
Please re-request review after conflicts are resolved and @mzieniukbw comments are addressed
|
@djsmith85 I've moved this to draft, since the corresponding SDK change is blocked by mobile. |



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37190
Waiting for SDK changes to move off of state access.
bitwarden/sdk-internal#1155
Please note: This PR will only be merged once the above SDK PR is merged, and the client sdk version is updated.
📔 Objective
Cleans up the ephemeral states that were shaped into a map to go via the repostiory state access. These are now accessed via the state bridge and no longer need these hacks.
📸 Screenshots