Skip to content

[PM-36414] [BEEEP] feat: Implement accessibility rotors for the vault list view. #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fedemkr wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

[PM-36414] [BEEEP] feat: Implement accessibility rotors for the vault list view. #2609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions BitwardenShared/UI/Vault/Vault/VaultList/VaultListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ private struct SearchableVaultListView: View {
}
.padding(.bottom, FloatingActionButton.bottomOffsetPadding)
.scrollView()
.accessibilityRotor("Sections") {
ForEach(sections.filter { !$0.name.isEmpty }) { section in
AccessibilityRotorEntry(section.name, id: section.id)
Comment on lines +326 to +328
Copy link
Copy Markdown
Collaborator

@matt-livefront matt-livefront May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Doesn't VoiceOver automatically allow you to navigate between headers with the rotor by default? I'm curious what this changes?

}
}
}

/// Creates a row in the list for the provided item.
Expand Down
2 changes: 2 additions & 0 deletions BitwardenShared/UI/Vault/Views/VaultListSectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ struct VaultListSectionView<Content: View>: View {
if showCount {
SectionHeaderView("\(section.name) (\(section.items.count))")
.accessibilityLabel("\(section.name), \(Localizations.xItems(section.items.count))")
.accessibilityAddTraits(.isHeader)
} else {
SectionHeaderView(section.name)
.accessibilityAddTraits(.isHeader)
Comment on lines +26 to +29
Copy link
Copy Markdown
Collaborator

@matt-livefront matt-livefront May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 It looks like we already apply this trait in SectionHeaderView itself. Curious if it's still needed here?

ios/BitwardenKit/UI/Platform/Application/Views/SectionHeaderView.swift

Line 19 in 4c765c5

.accessibilityAddTraits(.isHeader)

}

LazyVStack(alignment: .leading, spacing: 0) {
Expand Down
Loading