[PM-36414] [BEEEP] feat: Implement accessibility rotors for the vault list view.#2609
Draft
fedemkr wants to merge 1 commit into
Draft
[PM-36414] [BEEEP] feat: Implement accessibility rotors for the vault list view.#2609fedemkr wants to merge 1 commit into
fedemkr wants to merge 1 commit into
Conversation
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 87.20% 87.21%
=======================================
Files 1895 1895
Lines 167767 167774 +7
=======================================
+ Hits 146304 146317 +13
+ Misses 21463 21457 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+26
to
+29
| .accessibilityAddTraits(.isHeader) | ||
| } else { | ||
| SectionHeaderView(section.name) | ||
| .accessibilityAddTraits(.isHeader) |
Collaborator
There was a problem hiding this comment.
🤔 It looks like we already apply this trait in SectionHeaderView itself. Curious if it's still needed here?
Comment on lines
+326
to
+328
| .accessibilityRotor("Sections") { | ||
| ForEach(sections.filter { !$0.name.isEmpty }) { section in | ||
| AccessibilityRotorEntry(section.name, id: section.id) |
Collaborator
There was a problem hiding this comment.
❓ Doesn't VoiceOver automatically allow you to navigate between headers with the rotor by default? I'm curious what this changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-36414
📔 Objective
Implement accessibility rotors for the vault list view.
📸 Screenshots
iOS.VoiceOver.Rotor.headings.MP4