Skip to content

PM-27628 Rename Remove individual vault export policy #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+3 −3
Open

PM-27628 Rename Remove individual vault export policy #17335

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
940beb5
PM-27628 conditions for send and export links in left navbar
bmbitwarden Nov 11, 2025
3971893
Merge branch 'main' into PM-27628-conditional-send-export
bmbitwarden Nov 11, 2025
9a1ba36
PM-27628 resolved claude comment for pr
bmbitwarden Nov 11, 2025
c47c508
PM-27628 resolved claude comment for pr
bmbitwarden Nov 11, 2025
1b279a1
Merge branch 'main' into PM-27628-conditional-send-export
bmbitwarden Nov 13, 2025
344f07d
PM-27628 reverted earlier display conditionals and changed label
bmbitwarden Nov 18, 2025
4457a59
PM-27628 changed out keys as well
bmbitwarden Nov 20, 2025
aea570a
Merge branch 'main' into PM-27628-conditional-send-export
bmbitwarden Nov 20, 2025
f578cd9
PM-27628 revert description key change
bmbitwarden Nov 20, 2025
51ef141
Merge branch 'main' into PM-27628-conditional-send-export
bmbitwarden Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/web/src/locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6741,10 +6741,10 @@
"vaultTimeoutRangeError": {
"message": "Vault timeout is not within allowed range."
},
"disablePersonalVaultExport": {
"message": "Remove individual vault export"
"disableExport": {
Copy link

@claude claude bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Finding 1: Key renamed but 67 other locale files not updated

Renaming this key from disablePersonalVaultExport to disableExport will break translations in all non-English locales. The old key still exists in 67 other messages.json files:

apps/web/src/locales/ar/messages.json
apps/web/src/locales/de/messages.json
apps/web/src/locales/es/messages.json
... (64 more files)

Options:

  1. Update all 68 locale files - Rename the key in every messages.json file (keep existing translations)
  2. Revert key change - Keep disablePersonalVaultExport as the key, only update the English message

Since the message content changed ("Remove individual vault export" → "Remove export"), Option 1 is more appropriate as it signals to translators that retranslation is needed.

"message": "Remove export"
},
"disablePersonalVaultExportDescription": {
"disableExportDescription": {
"message": "Do not allow members to export data from their individual vault."
},
"vaultExportDisabled": {
Expand Down
4 changes: 2 additions & 2 deletions ...admin-console/policies/policy-edit-definitions/disable-personal-vault-export.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
import { SharedModule } from "@bitwarden/web-vault/app/shared";

export class DisablePersonalVaultExportPolicy extends BasePolicyEditDefinition {
name = "disablePersonalVaultExport";
description = "disablePersonalVaultExportDescription";
name = "disableExport";
description = "disableExportDescription";
type = PolicyType.DisablePersonalVaultExport;
component = DisablePersonalVaultExportPolicyComponent;
}
Expand Down
Loading