PM-27628 Rename Remove individual vault export policy

[bmbitwarden]

Relates to: PM-27628

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27628
https://bitwarden.atlassian.net/browse/PM-7853

📔 Objective

Rename Remove individual vault export policy to Remove export

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

[github-actions]

Checkmarx One – Scan Summary & Details – f3de6b40-b86c-4ca7-9b17-26005365f1b8

Great job! No new security vulnerabilities introduced in this pull request

[willmartian]

Perhaps a PolicyService.policyAppliesToActiveUser$ helper method would be an appropriate addition given how often we combine it with AccountService.activeAccount$

[willmartian]

Oh, welcome to Bitwarden! Happy first PR in clients. 🎉

[claude]

Claude finished @bmbitwarden's task —— View job

---

Code Review

I've analyzed the PR and djsmith85's concern is partially valid. The situation requires clarification:

---

Summary

The PR changes both the i18n key (disablePersonalVaultExport → disableExport) and the message ("Remove individual vault export" → "Remove export"). This creates a critical incomplete migration issue.

---

Findings

❌ Finding 1: Incomplete i18n key migration will break translations

The change renames the key in en/messages.json, but this key exists in 68 translation files (one per locale). All 67 non-English translations still use the old key name, which means:

• Non-English users will see outdated text or missing translations
• The app's i18n system won't find the new disableExport key in other locales

Current state:

• English (en/messages.json): Uses new key disableExport ✓
• 67 other locales: Still use old key disablePersonalVaultExport ✗

Affected locale files (67 total)

All locale files under apps/web/src/locales/*/messages.json except en/messages.json contain the old disablePersonalVaultExport key and need updating.

---

⚠️ Finding 2: Message content changed, so key change is justified

djsmith85 stated "if the message is not changed, then please don't replace the key." However, the message was changed:

• Before: "Remove individual vault export"
• After: "Remove export"

This is a semantic change that removes "individual vault", making it shorter and potentially broader in meaning. This justifies creating a new key to signal translators that retranslation is needed.

Clarification needed: Is the key change intentional given the message change, or should we keep the old key?

---

Recommendations

Option 1: Complete the key migration (if rename is intentional)

1. Rename disablePersonalVaultExport → disableExport in all 67 remaining locale files
2. Keep existing translated messages unchanged (translators will update them later when they see the new English text)
3. This prevents breaking non-English locales immediately

Option 2: Revert key change (if broader impact isn't desired)

1. Keep key as disablePersonalVaultExport
2. Only update the English message to "Remove export"
3. Simpler change with less risk of breaking translations

Given this PR's scope ("Rename Remove individual vault export policy"), Option 1 better aligns with the intent but requires updating 67 additional files.

---

Review Complete

Summary: The key change is justified by the message change, but the implementation is incomplete. 67 locale files need the same key rename to prevent breaking non-English translations.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 41.25%. Comparing base (e23b2d0) to head (51ef141).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...nitions/disable-personal-vault-export.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17335   +/-   ##
=======================================
  Coverage   41.25%   41.25%           
=======================================
  Files        3546     3546           
  Lines      102040   102040           
  Branches    15308    15308           
=======================================
+ Hits        42095    42099    +4     
+ Misses      58180    58177    -3     
+ Partials     1765     1764    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Hinton]

Putting a hold on this until the discussion in jira are resolved. Browser and desktop should probably also be updated since the jira ticket contains figma designs of the browser extension.

[Hinton]

Can you please update the PR title and description to reflect the new scope.

[Hinton]

• I18n keys changed ✅
• All usages updated ✅

[claude]

❌ Finding 1: Key renamed but 67 other locale files not updated

Renaming this key from disablePersonalVaultExport to disableExport will break translations in all non-English locales. The old key still exists in 67 other messages.json files:

apps/web/src/locales/ar/messages.json
apps/web/src/locales/de/messages.json
apps/web/src/locales/es/messages.json
... (64 more files)

Options:

1. Update all 68 locale files - Rename the key in every messages.json file (keep existing translations)
2. Revert key change - Keep disablePersonalVaultExport as the key, only update the English message

Since the message content changed ("Remove individual vault export" → "Remove export"), Option 1 is more appropriate as it signals to translators that retranslation is needed.