Skip to content

chore/SRE-583 Deprecate usage of Auth-Email Header #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sneakernuts merged 10 commits into from
Aug 18, 2025
Merged

chore/SRE-583 Deprecate usage of Auth-Email Header #5097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
38ed509
chore/SRE-583 Deprecate usage of Auth-Email Header
bitwarden-charlie Feb 28, 2025
3baa89b
removed authEmail from IdentityServiceImpl
sneakernuts Aug 18, 2025
f4683bb
Removed import for base64UrlEncode
sneakernuts Aug 18, 2025
ec2f2bd
Merge branch 'main' into chore/SRE-583-Deprecate-usage-of-Auth-Email-…
sneakernuts Aug 18, 2025
d2b26d6
removing import for base64UrlEncode
sneakernuts Aug 18, 2025
a38b0bf
removed import for Header
sneakernuts Aug 18, 2025
04d7075
Merge remote-tracking branch 'origin/main' into chore/SRE-583-Depreca…
sneakernuts Aug 18, 2025
380085b
Merge remote-tracking branch 'origin/main' into chore/SRE-583-Depreca…
sneakernuts Aug 18, 2025
6977339
Merge remote-tracking branch 'origin/main' into chore/SRE-583-Depreca…
sneakernuts Aug 18, 2025
fea0150
Merge remote-tracking branch 'origin/main' into chore/SRE-583-Depreca…
sneakernuts Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedIdentityApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import retrofit2.http.Body
import retrofit2.http.Field
import retrofit2.http.FormUrlEncoded
import retrofit2.http.GET
import retrofit2.http.Header
import retrofit2.http.POST
import retrofit2.http.Query

Expand All @@ -33,7 +32,6 @@ internal interface UnauthenticatedIdentityApi {
@Field(value = "scope", encoded = true) scope: String,
@Field(value = "client_id") clientId: String,
@Field(value = "username") email: String,
@Header(value = "Auth-Email") authEmail: String,
@Field(value = "password") passwordHash: String?,
@Field(value = "deviceIdentifier") deviceIdentifier: String,
@Field(value = "deviceName") deviceName: String,
Expand Down
2 changes: 0 additions & 2 deletions network/src/main/kotlin/com/bitwarden/network/service/IdentityServiceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import com.bitwarden.network.model.VerifyEmailTokenResponseJson
import com.bitwarden.network.model.toBitwardenError
import com.bitwarden.network.util.DeviceModelProvider
import com.bitwarden.network.util.NetworkErrorCode
import com.bitwarden.network.util.base64UrlEncode
import com.bitwarden.network.util.executeForNetworkResult
import com.bitwarden.network.util.getNetworkErrorCodeOrNull
import com.bitwarden.network.util.parseErrorBodyOrNull
Expand Down Expand Up @@ -63,7 +62,6 @@ internal class IdentityServiceImpl(
.getToken(
scope = "api offline_access",
clientId = "mobile",
authEmail = email.base64UrlEncode(),
deviceIdentifier = uniqueAppId,
deviceName = deviceModelProvider.deviceModel,
deviceType = "0",
Expand Down