Skip to content

chore/SRE-583 Deprecate usage of Auth-Email Header #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bitwarden-charlie
Copy link

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-583

📔 Objective

Deprecate usage of Auth-Email Header

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsaddda840-f1f9-4260-ab39-311f85f5fc17

Fixed Issues (8)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 420
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 336
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 441
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 465
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 514
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 565
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 292
MEDIUM Use_of_Hardcoded_Password /app/src/test/java/com/x8bit/bitwarden/data/platform/datasource/network/ssl/CertificateManagerTest.kt: 611

@@ -33,7 +33,7 @@ interface UnauthenticatedIdentityApi {
@Field(value = "scope", encoded = true) scope: String,
@Field(value = "client_id") clientId: String,
@Field(value = "username") email: String,
@Header(value = "Auth-Email") authEmail: String,
// Auth-Email header is deprecated and no longer needed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this comment, you can just delete it.

Also, you need to remove this parameters usage in the IdentityServiceImpl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants