-
Notifications
You must be signed in to change notification settings - Fork 927
chore/SRE-583 Deprecate usage of Auth-Email Header #5097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/SRE-583 Deprecate usage of Auth-Email Header #5097
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
...main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/UnauthenticatedIdentityApi.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/IdentityServiceImpl.kt
Show resolved
Hide resolved
|
Looks like you need a rebase so resolve the conflicts |
network/src/main/kotlin/com/bitwarden/network/api/UnauthenticatedIdentityApi.kt
Show resolved
Hide resolved
…te-usage-of-Auth-Email-Header
…te-usage-of-Auth-Email-Header
…te-usage-of-Auth-Email-Header
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5097 +/- ##
==========================================
- Coverage 83.90% 83.90% -0.01%
==========================================
Files 692 692
Lines 52872 52871 -1
Branches 7260 7260
==========================================
- Hits 44364 44363 -1
Misses 5967 5967
Partials 2541 2541 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…te-usage-of-Auth-Email-Header
vvolkgang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Updated the PR description with a link to the server PR: bitwarden/server#5709

🎟️ Tracking
https://bitwarden.atlassian.net/browse/SRE-583
📔 Objective
Deprecate usage of Auth-Email Header
Server side changes: bitwarden/server#5709
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes