Skip to content

Conversation

@bitwarden-charlie
Copy link
Contributor

@bitwarden-charlie bitwarden-charlie commented Apr 25, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SRE-583

📔 Objective

Deprecate usage of Auth-Email Header

Server side changes: bitwarden/server#5709

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Logo
Checkmarx One – Scan Summary & Details7f60bf4b-8ca3-4f44-86ce-f94fef1a3f33

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront
Copy link
Collaborator

Looks like you need a rebase so resolve the conflicts

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.90%. Comparing base (aca4b05) to head (fea0150).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5097      +/-   ##
==========================================
- Coverage   83.90%   83.90%   -0.01%     
==========================================
  Files         692      692              
  Lines       52872    52871       -1     
  Branches     7260     7260              
==========================================
- Hits        44364    44363       -1     
  Misses       5967     5967              
  Partials     2541     2541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Updated the PR description with a link to the server PR: bitwarden/server#5709

@sneakernuts sneakernuts added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit a999592 Aug 18, 2025
9 checks passed
@sneakernuts sneakernuts deleted the chore/SRE-583-Deprecate-usage-of-Auth-Email-Header branch August 18, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants