Move toposorting onto DiGraph
directly, and cleanup error handling
#21608
+263
−220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ScheduleBuildError
introspection and handling #20256,ScheduleGraph::topsort_graph
no longer usesself
, so let's put it directly onDiGraph
.Solution
ScheduleGraph::topsort_graph
toDiGraph::toposort
.DiGraphToposortError
withLoop
andCycle
variants, which is wrapped to replaceScheduleBuildError::HierarchyLoop
,HierarchyCycle
,DependencyLoop
, andDependencyCycle
.ScheduleBuildError::FlatDependencySort
variant to detect issues specifically with the flattened dependency graph.ReportCycles
:DiGraph::toposort
returns an error that should be wrapped at the callsite, negating the need for this type.simple_cycles_in_component
ontoDiGraph
(formerly a free-floating function).Testing
Updated and reused current tests.