Give change_detection
its own folder and split into multiple files
#21604
+1,919
−1,882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
change_detection.rs
is a bit big at ~1900 lines and its contents are pretty varied, so it ought to be split up.Solution
Split
change_detection.rs
into 4 files:mod.rs
: Re-exports, some constants, testingparams.rs
: Change-detecting system/query parameters likeRef
andRes
traits.rs
: TheDetectChanges
andDetectChangesMut
traits and the macros used internally to implement those traits (and some others) for the above parametersmaybe_location.rs
:MaybeLocation
and its implsThis shouldn't change anything publicly, since everything's still in the same module.
I'd also like to move
component/tick.rs
into this module, but that would break stuff, so that'll be its own PR.