Skip to content

Fix memory leak in EntitySpecializationTicks #21599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix memory leak in EntitySpecializationTicks #21599

wants to merge 1 commit into from
+5 −1

Conversation

EmbersArc
Copy link
Contributor

Objective

Fixes #21526

Solution

  • Only require specialization when the entity still exists.

Testing

  • Tested with the second example in the issue while printing the size of the EntitySpecializationTicks.

@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Oct 19, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Oct 19, 2025
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tychedelia tychedelia Awaiting requested review from tychedelia

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: No status

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

Memory leak in EntitySpecializationTicks when a material uses NotShadowCaster

2 participants

@EmbersArc @alice-i-cecile