Skip to content

docs(camera): clarify ndc_to_world method documentation #21571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(camera): clarify ndc_to_world method documentation #21571

wants to merge 1 commit into from
+6 −5

Conversation

WaterWhisperer
Copy link
Contributor

Objective

Fixes #16809

Solution

  • Correct NDC coordinate ranges and depth interpretation
  • Fix method reference from world_to_viewport to viewport_to_world
  • Update parameter name in error condition from world_position to ndc_point
  • Clarify that returned world position is not limited to NDC

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Camera User-facing camera APIs and controllers. labels Oct 19, 2025
@alice-i-cecile alice-i-cecile added X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@dloukadakis dloukadakis dloukadakis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Camera User-facing camera APIs and controllers. A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ndc_to_world seems to have wrong output range in documentation

3 participants

@WaterWhisperer @alice-i-cecile @dloukadakis