Fix assimp build with --dynamic_mode off #4724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <[email protected]>
Member
|
Hello @bazelbuild/bcr-maintainers, modules (assimp) have been updated in this PR. |
bazel-io
approved these changes
May 30, 2025
Member
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
Contributor
Author
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
bazel-io
added
the
auto-merged
9 tasks
shameekganguly
added a commit
to gazebosim/gz-common
that referenced
this pull request
May 30, 2025
Fixes bazel build with --dynamic_mode=off by pulling in a newer version of assimp (bumped in bazelbuild/bazel-central-registry#4724, please read the PR description there for details on the error and the fix). Signed-off-by: Shameek Ganguly <[email protected]>
filmil
pushed a commit
to filmil/bazel-central-registry
that referenced
this pull request
Jun 23, 2025
Fixes linker issues when building with `--dynamic_mode off` that come from missing symbols in the IO plugin libraries. The fix is to merge all IO plugin sources directly into the `@assimp` target instead of building them as separate cc libraries. This change is backward compatible since the plugin libraries were not publicly visible. For the sake of logical organization, I have kept the sources for each IO plugin as separate `filegroup` targets that are merged into `srcs` for the `@assimp` library target. Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linker issues when building with
--dynamic_mode offthat come from missing symbols in the IO plugin libraries. The fix is to merge all IO plugin sources directly into the@assimptarget instead of building them as separate cc libraries. This change is backward compatible since the plugin libraries were not publicly visible. For the sake of logical organization, I have kept the sources for each IO plugin as separatefilegrouptargets that are merged intosrcsfor the@assimplibrary target.