Skip to content

Commit c921500

Browse files
Fix assimp build with --dynamic_mode off (#4724)
Fixes linker issues when building with `--dynamic_mode off` that come from missing symbols in the IO plugin libraries. The fix is to merge all IO plugin sources directly into the `@assimp` target instead of building them as separate cc libraries. This change is backward compatible since the plugin libraries were not publicly visible. For the sake of logical organization, I have kept the sources for each IO plugin as separate `filegroup` targets that are merged into `srcs` for the `@assimp` library target. Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
1 parent d647d42 commit c921500

File tree

6 files changed

+865
-1
lines changed

6 files changed

+865
-1
lines changed
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
module(
2+
name = "assimp",
3+
version = "5.4.3.bcr.3",
4+
compatibility_level = 0,
5+
bazel_compatibility = [">=7.2.1"],
6+
)
7+
8+
bazel_dep(name = "bazel_skylib", version = "1.7.1")
9+
bazel_dep(name = "pugixml", version = "1.15")
10+
bazel_dep(name = "rapidjson", version = "1.1.0.bcr.20241007")
11+
bazel_dep(name = "rules_cc", version = "0.1.1")
12+
bazel_dep(name = "zlib", version = "1.3.1.bcr.6")

0 commit comments

Comments
 (0)