Skip to content

MINOR: Remove unused mkMapOfPartitionRacks method #19797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chia7712 merged 5 commits into from
May 25, 2025
Merged

MINOR: Remove unused mkMapOfPartitionRacks method #19797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87a9e7d
MINOR: Remove unused mkMapOfPartitionRacks method
Yunyung May 23, 2025
80155dc
Merge branch 'trunk' into remove_unused_mkMapOfPartitionRacks_method
Yunyung May 23, 2025
05875f0
spotlessApply
Yunyung May 23, 2025
40812c3
Remove mkMapOfPartitionRacks in GroupCoordinatorRecordHelpersTest
Yunyung May 23, 2025
5c05064
spotlessApply
Yunyung May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions ...r/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
Expand Down Expand Up @@ -898,21 +897,4 @@ public void testNewShareGroupEpochRecord() {
10
));
}

/**
* Creates a map of partitions to racks for testing.
*
* @param numPartitions The number of partitions for the topic.
*
* For testing purposes, the following criteria are used:
* - Number of replicas for each partition: 2
* - Number of racks available to the cluster: 4
*/
public static Map<Integer, Set<String>> mkMapOfPartitionRacks(int numPartitions) {
Map<Integer, Set<String>> partitionRacks = new HashMap<>(numPartitions);
for (int i = 0; i < numPartitions; i++) {
partitionRacks.put(i, new HashSet<>(Arrays.asList("rack" + i % 4, "rack" + (i + 1) % 4)));
}
return partitionRacks;
}
}
2 changes: 1 addition & 1 deletion jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ClientSideAssignorBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ private List<PartitionInfo> partitionInfos(String topic, int numberOfPartitions,
for (int i = 0; i < numberOfPartitions; i++) {
Node[] replicas = new Node[3];
for (int j = 0; j < 3; j++) {
// Assign nodes based on partition number to mimic mkMapOfPartitionRacks logic.
// Assign nodes based on partition number.
int nodeIndex = (i + j) % NUMBER_OF_RACKS;
replicas[j] = nodes.get(nodeIndex);
}
Expand Down
13 changes: 0 additions & 13 deletions jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import org.openjdk.jmh.annotations.Threads;
import org.openjdk.jmh.annotations.Warmup;

import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
Expand Down Expand Up @@ -186,18 +185,6 @@ private Optional<String> rackId(int memberIndex) {
return isRackAware ? Optional.of("rack" + memberIndex % NUMBER_OF_RACKS) : Optional.empty();
}

private static Map<Integer, Set<String>> mkMapOfPartitionRacks(int numPartitions) {
Map<Integer, Set<String>> partitionRacks = new HashMap<>(numPartitions);
for (int i = 0; i < numPartitions; i++) {
partitionRacks.put(i, new HashSet<>(Arrays.asList(
"rack" + i % NUMBER_OF_RACKS,
"rack" + (i + 1) % NUMBER_OF_RACKS,
"rack" + (i + 2) % NUMBER_OF_RACKS
)));
}
return partitionRacks;
}

private void simulateIncrementalRebalance() {
GroupAssignment initialAssignment = partitionAssignor.assign(groupSpec, subscribedTopicDescriber);
Map<String, MemberAssignment> members = initialAssignment.members();
Expand Down