Skip to content

MINOR: Remove unused mkMapOfPartitionRacks method #19797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

MINOR: Remove unused mkMapOfPartitionRacks method #19797

wants to merge 5 commits into from
+1 −32

Conversation

Yunyung
Copy link
Collaborator

@Yunyung Yunyung commented May 23, 2025 •
edited by github-actions bot
Loading

The mkMapOfPartitionRacks in ServerSideAssignorBenchmark.java was
introduced in 8013657, and the one in
GroupCoordinatorRecordHelpersTest.java was introduced in
3709901.

Both have not been used since bb97d63.

@github-actions github-actions bot added the triage PRs from the community label May 23, 2025
@Yunyung Yunyung added ci-approved and removed triage PRs from the community labels May 23, 2025
@mingyen066
Copy link
Collaborator

Could we also remove mkMapOfPartitionRacks in GroupCoordinatorRecordHelpersTest.java ?

https://github.com/apache/kafka/blob/trunk/group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpersTest.java#L911

@Yunyung
Copy link
Collaborator Author

Yunyung commented May 23, 2025

Could we also remove mkMapOfPartitionRacks in GroupCoordinatorRecordHelpersTest.java ?

Done. Thanks.

m1a2st
m1a2st approved these changes May 24, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1a2st m1a2st m1a2st approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-approved performance small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yunyung @mingyen066 @m1a2st