Skip to content

tsaucer/run TPC-H examples in CI #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 21, 2024

Conversation

timsaucer
Copy link
Contributor

@timsaucer timsaucer commented May 21, 2024

Which issue does this PR close?

Closes #696
Closes #712

Rationale for this change

This PR sets up a work flow to generate TPH-C 1Gb data set in CI, runs the 22 examples, and compares their results to the
known answer file. By adding this PR we improve the robustness of our test suite.

What changes are included in this PR?

This PR adds the following changes:

  • Adds CI workflow to generate TPH-C data set and answer file. The results are cached from run to run.
  • Adds pytest file to run all 22 examples and compare them to the answer file
  • Exposes substring operation that was missing. Sometime between 36.0.0 and 38.0.0 substr was performing the operation instead.

Are there any user-facing changes?

substring function exposed in python.

Additional context

This PR replaces #710 which contains a lot of intermediate testing steps. This MR should be cleaner to review.

@timsaucer
Copy link
Contributor Author

@Michael-J-Ward It looks like we have a potential regression between 37.1.0 and 38.0.0. Namely substr on 37.1.0 would accept a start and length, the parameters that should apply to substring. I was using substr incorrectly but it worked by accident on 37.1.0 because substr and substring were calling the same underlying function. In 38.0.0 this is updated and substr now fails if you pass it two parameters.

This PR includes exposing substring which was missing on the python side.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you @timsaucer

@andygrove andygrove merged commit dfbb3ca into apache:main May 21, 2024
@timsaucer timsaucer deleted the tsaucer/run-tpch-examples-in-ci branch May 23, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in substr performance from 37.1.0 to 38.0.0 Ensure examples stay updated in CI.
2 participants